When checking out a book that is already checked out to another patron the confirmation boxes display "Yes, check out (Y)" and the HTML has an "accesskey" element to allow confirmation via the keyboard We should duplicate the same functionality for hold confirmation boxes (and probably elsewhere eventually) I suggest: "c" Confirm hold (C) "p" Confirm hold and print (P) "i" Ignore (I) "x" Cancel hold (X)
Created attachment 121418 [details] [review] Bug 20688: Add accesskeys to hold modals This patch adds accesskey elements to the hold modals during checkin For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey To test: 1 - Place some holds on items 2 - Check in an item with a hold at a branch that requires transfer 3 - Use accesskey I to ignore 4 - Use accesskey Y to confirm and transfer 5 - Check in again 6 - Use accesskey Y to confirm 7 - Repeat 4-6 with a new hold but use the accesskey P to print the slip 8 - Check in the item again ans use accesskey X to cancel
Created attachment 121419 [details] [review] Bug 20688: Add accesskeys for transfers To test: 1 - Disable AutomaticItemReturn systme preference 2 - Check in an item that does not float at a branch no it's home 3 - Test new accesskeys for I,N,Y,P 4 - With transfer confirmed check the item in at a wrong branch 5 - Test accesskeys Y,P,X
Created attachment 121432 [details] [review] Bug 20688: Add accesskeys to hold modals This patch adds accesskey elements to the hold modals during checkin For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey To test: 1 - Place some holds on items 2 - Check in an item with a hold at a branch that requires transfer 3 - Use accesskey I to ignore 4 - Use accesskey Y to confirm and transfer 5 - Check in again 6 - Use accesskey Y to confirm 7 - Repeat 4-6 with a new hold but use the accesskey P to print the slip 8 - Check in the item again ans use accesskey X to cancel Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 121433 [details] [review] Bug 20688: Add accesskeys for transfers To test: 1 - Disable AutomaticItemReturn systme preference 2 - Check in an item that does not float at a branch no it's home 3 - Test new accesskeys for I,N,Y,P 4 - With transfer confirmed check the item in at a wrong branch 5 - Test accesskeys Y,P,X Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20688: Add accesskeys to hold modals Applying: Bug 20688: Add accesskeys for transfers error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). error: could not build fake ancestor Patch failed at 0001 Bug 20688: Add accesskeys for transfers The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20688-Add-accesskeys-for-transfers-nNbAY7.patch
Created attachment 123295 [details] [review] Bug 20688: Add accesskeys to hold modals This patch adds accesskey elements to the hold modals during checkin For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey To test: 1 - Place some holds on items 2 - Check in an item with a hold at a branch that requires transfer 3 - Use accesskey I to ignore 4 - Use accesskey Y to confirm and transfer 5 - Check in again 6 - Use accesskey Y to confirm 7 - Repeat 4-6 with a new hold but use the accesskey P to print the slip 8 - Check in the item again ans use accesskey X to cancel Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 123296 [details] [review] Bug 20688: Add accesskeys for transfers To test: 1 - Disable AutomaticItemReturn systme preference 2 - Check in an item that does not float at a branch no it's home 3 - Test new accesskeys for I,N,Y,P 4 - With transfer confirmed check the item in at a wrong branch 5 - Test accesskeys Y,P,X Signed-off-by: Owen Leonard <oleonard@myacpl.org>
> For tips on how to access the accesskeys: > https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey This was really helpful, thx!
Created attachment 124229 [details] [review] Bug 20688: Add accesskeys to hold modals This patch adds accesskey elements to the hold modals during checkin For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey To test: 1 - Place some holds on items 2 - Check in an item with a hold at a branch that requires transfer 3 - Use accesskey I to ignore 4 - Use accesskey Y to confirm and transfer 5 - Check in again 6 - Use accesskey Y to confirm 7 - Repeat 4-6 with a new hold but use the accesskey P to print the slip 8 - Check in the item again ans use accesskey X to cancel Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 124230 [details] [review] Bug 20688: Add accesskeys for transfers To test: 1 - Disable AutomaticItemReturn systme preference 2 - Check in an item that does not float at a branch no it's home 3 - Test new accesskeys for I,N,Y,P 4 - With transfer confirmed check the item in at a wrong branch 5 - Test accesskeys Y,P,X Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I believe the info on how to access the accesskeys with different browsers would make a nice addition somewhere in the manual.
Pushed to master for 21.11, thanks to everybody involved!