Bugzilla – Attachment 151779 Details for
Bug 22135
Inventory tool doesn't export "out of order" problem to CSV
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22135: Display 'shelved out of order' error in inventory CSV export
Bug-22135-Display-shelved-out-of-order-error-in-in.patch (text/plain), 2.26 KB, created by
Katrin Fischer
on 2023-05-29 15:47:57 UTC
(
hide
)
Description:
Bug 22135: Display 'shelved out of order' error in inventory CSV export
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-05-29 15:47:57 UTC
Size:
2.26 KB
patch
obsolete
>From 82d654d6a9d9b22a2248e15f93446a00136346b9 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Mon, 29 May 2023 15:41:44 +0000 >Subject: [PATCH] Bug 22135: Display 'shelved out of order' error in inventory > CSV export > >When using the inventory tool with an uploaded barcode file >and checking the "Compare barcodes list to results", >"Check barcodes list for items shelved out of order" and >"Export to CSV file" checkboxes, the resulting CSV file showed >a blank in the "problem" column for items with out of order >callnumbers. With this patch, you'll see "Shelved out of order". > >To test: >* Create 3 items with callnumbers and barcodes a, b, and c >* Go to Cataloguing > Inventory >* Enter a c b (each on its own line) into the barcode field >* Check "Compare barcodes list to results" >* Check "Check barcodes list for items shelved out of order" >* Check "Export to CSV file" (at the bottom) >* Verify the file has empty lines in the problem column >* Apply patch >* Repeat test, the empty lines should now read: "Shelved out of order" > >Note: Also fixes "problem" to "Problem" to make capitalization >consistent. All those strings are currently not translatable, >this will be filed separately. > >Co-authored-by: Mark Alexander <marka@pobox.com> >--- > tools/inventory.pl | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/tools/inventory.pl b/tools/inventory.pl >index ace4e7cb7b..a2bd89e6ed 100755 >--- a/tools/inventory.pl >+++ b/tools/inventory.pl >@@ -405,7 +405,7 @@ if (defined $input->param('CSVexport') && $input->param('CSVexport') eq 'on'){ > my ( $table, $column ) = split '\.', $key; > push @translated_keys, NormalizeString($columns->{$table}->{$column} // ''); > } >- push @translated_keys, 'problem' if $uploadbarcodes; >+ push @translated_keys, 'Problem' if $uploadbarcodes; > > $csv->combine(@translated_keys); > print $csv->string, "\n"; >@@ -428,6 +428,8 @@ if (defined $input->param('CSVexport') && $input->param('CSVexport') eq 'on'){ > $errstr .= "no barcode,"; > } elsif( $key eq 'checkedout' ) { > $errstr .= "checked out,"; >+ } elsif( $key eq 'out_of_order' ) { >+ $errstr .= "shelved out of order,"; > } > } > $errstr =~ s/,$//; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22135
:
84013
|
151778
|
151779
|
151955
|
155140