Created attachment 84013 [details] [review] Fix for out of order problem seen as blank in CSV exported by inventory tool When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file shows a blank in the "problem" column for items with out of order callnumbers. I was able to fix this using the attached patch.
Created attachment 151778 [details] [review] Bug 22135: Display 'shelved out of order' error in inventory CSV export When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file showed a blank in the "problem" column for items with out of order callnumbers. With this patch, you'll see "Shelved out of order". To test: * Create 3 items with callnumbers and barcodes a, b, and c * Go to Cataloguing > Inventory * Enter a c b (each on its own line) into the barcode field * Check "Compare barcodes list to results" * Check "Check barcodes list for items shelved out of order" * Check "Export to CSV file" (at the bottom) * Verify the file has empty lines in the problem column * Apply patch * Repeat test, the empty lines should now read: "Shelved out of order" Note: Also fixes "problem" to "Problem" to make capitalization consistent. All those strings are currently not translatable, this will be filed separately.
Created attachment 151779 [details] [review] Bug 22135: Display 'shelved out of order' error in inventory CSV export When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file showed a blank in the "problem" column for items with out of order callnumbers. With this patch, you'll see "Shelved out of order". To test: * Create 3 items with callnumbers and barcodes a, b, and c * Go to Cataloguing > Inventory * Enter a c b (each on its own line) into the barcode field * Check "Compare barcodes list to results" * Check "Check barcodes list for items shelved out of order" * Check "Export to CSV file" (at the bottom) * Verify the file has empty lines in the problem column * Apply patch * Repeat test, the empty lines should now read: "Shelved out of order" Note: Also fixes "problem" to "Problem" to make capitalization consistent. All those strings are currently not translatable, this will be filed separately. Co-authored-by: Mark Alexander <marka@pobox.com>
Realized too late that there was already an incomplete patch file from Mark, so I added him as a co-author. We ended up with the same solution :)
Created attachment 151955 [details] [review] Bug 22135: Display 'shelved out of order' error in inventory CSV export When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file showed a blank in the "problem" column for items with out of order callnumbers. With this patch, you'll see "Shelved out of order". To test: * Create 3 items with callnumbers and barcodes a, b, and c * Go to Cataloguing > Inventory * Enter a c b (each on its own line) into the barcode field * Check "Compare barcodes list to results" * Check "Check barcodes list for items shelved out of order" * Check "Export to CSV file" (at the bottom) * Verify the file has empty lines in the problem column * Apply patch * Repeat test, the empty lines should now read: "Shelved out of order" Note: Also fixes "problem" to "Problem" to make capitalization consistent. All those strings are currently not translatable, this will be filed separately. Co-authored-by: Mark Alexander <marka@pobox.com> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 155140 [details] [review] Bug 22135: Display 'shelved out of order' error in inventory CSV export When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file showed a blank in the "problem" column for items with out of order callnumbers. With this patch, you'll see "Shelved out of order". To test: * Create 3 items with callnumbers and barcodes a, b, and c * Go to Cataloguing > Inventory * Enter a c b (each on its own line) into the barcode field * Check "Compare barcodes list to results" * Check "Check barcodes list for items shelved out of order" * Check "Export to CSV file" (at the bottom) * Verify the file has empty lines in the problem column * Apply patch * Repeat test, the empty lines should now read: "Shelved out of order" Note: Also fixes "problem" to "Problem" to make capitalization consistent. All those strings are currently not translatable, this will be filed separately. Co-authored-by: Mark Alexander <marka@pobox.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x