Bugzilla – Attachment 15804 Details for
Bug 9734
String::Random is marked as optional, but C4::Members requires it
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9734 - String::Random is marked as optional, but C4::Members requires it
Bug-9734---StringRandom-is-marked-as-optional-but-.patch (text/plain), 1.79 KB, created by
Kyle M Hall
on 2013-03-01 15:56:34 UTC
(
hide
)
Description:
Bug 9734 - String::Random is marked as optional, but C4::Members requires it
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2013-03-01 15:56:34 UTC
Size:
1.79 KB
patch
obsolete
>From 57c94acf21acdf55b3a854b2199d55b7879b13ee Mon Sep 17 00:00:00 2001 >From: MJ Ray <mjr@phonecoop.coop> >Date: Thu, 28 Feb 2013 15:47:27 +0000 >Subject: [PATCH] Bug 9734 - String::Random is marked as optional, but C4::Members requires it > >jcamins confirmed on IRC it is not optional. > >To test: >1) perl koha_perl_deps.pl -a |grep String::Random >2) notice the "No" in the last column - it should be Yes >3) apply patch and repeat same steps, looking for Yes. >4) prove t/Installer_PerlModules.t # which checks String::Random is required > >Sponsored-by: software.coop >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Installer/PerlDependencies.pm | 2 +- > t/Installer_PerlModules.t | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm >index 41fa8db..83ba962 100644 >--- a/C4/Installer/PerlDependencies.pm >+++ b/C4/Installer/PerlDependencies.pm >@@ -631,7 +631,7 @@ our $PERL_DEPS = { > }, > 'String::Random' => { > 'usage' => 'OpacSelfRegistration', >- 'required' => '0', >+ 'required' => '1', > 'min_ver' => '0.22', > }, > }; >diff --git a/t/Installer_PerlModules.t b/t/Installer_PerlModules.t >index f64ed85..c3ed715 100755 >--- a/t/Installer_PerlModules.t >+++ b/t/Installer_PerlModules.t >@@ -6,7 +6,7 @@ > use strict; > use warnings; > >-use Test::More tests => 15; >+use Test::More tests => 16; > > BEGIN { > use_ok('C4::Installer::PerlModules'); >@@ -35,3 +35,4 @@ ok ($modules->module_count() >10 , 'count should be greater than 10'); > my @module_list = $modules->module_list; > %params = map { $_ => 1 } @module_list; > ok (exists($params{"DBI"}), 'DBI exists in array'); >+is ($modules->required('module'=>"String::Random"),1, 'String::Random should return 1 since required'); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9734
:
15776
|
15777
|
15804
|
15972