Bug 9734 - String::Random is marked as optional, but C4::Members requires it
Summary: String::Random is marked as optional, but C4::Members requires it
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: Main
Hardware: All All
: P2 normal (vote)
Assignee: MJ Ray (software.coop)
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-28 15:44 UTC by MJ Ray (software.coop)
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9734 - String::Random is marked as optional, but C4::Members requires it (1005 bytes, patch)
2013-02-28 15:50 UTC, MJ Ray (software.coop)
Details | Diff | Splinter Review
Bug 9734 - String::Random is marked as optional, but C4::Members requires it (1.74 KB, patch)
2013-02-28 16:04 UTC, MJ Ray (software.coop)
Details | Diff | Splinter Review
Bug 9734 - String::Random is marked as optional, but C4::Members requires it (1.79 KB, patch)
2013-03-01 15:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9734 - String::Random is marked as optional, but C4::Members requires it (1.85 KB, patch)
2013-03-08 11:27 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description MJ Ray (software.coop) 2013-02-28 15:44:01 UTC
jcamins confirmed on IRC it is not optional.
Comment 1 MJ Ray (software.coop) 2013-02-28 15:50:57 UTC Comment hidden (obsolete)
Comment 2 MJ Ray (software.coop) 2013-02-28 16:04:14 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-03-01 15:56:34 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-03-08 11:26:30 UTC
QA comment:

Maybe it would be easy not to use this dependency and implement a simple routine to do the same thing (in order to avoid an additional dependency).
But that's not really the question here.

This patch marks the String::Random module as mandatory.

Marked as Passed QA.
Comment 5 Jonathan Druart 2013-03-08 11:27:11 UTC
Created attachment 15972 [details] [review]
Bug 9734 - String::Random is marked as optional, but C4::Members requires it

jcamins confirmed on IRC it is not optional.

To test:
1) perl koha_perl_deps.pl -a |grep String::Random
2) notice the "No" in the last column - it should be Yes
3) apply patch and repeat same steps, looking for Yes.
4) prove t/Installer_PerlModules.t # which checks String::Random is required

Sponsored-by: software.coop
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Jared Camins-Esakov 2013-03-11 11:34:54 UTC
This patch has been pushed to master.