Bugzilla – Attachment 15885 Details for
Bug 9450
Use DataTables in cataloging Z39.50 search results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results
Bug-9450-Revised-Use-DataTables-in-cataloging-Z395.patch (text/plain), 3.40 KB, created by
Jonathan Druart
on 2013-03-05 10:15:01 UTC
(
hide
)
Description:
Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-03-05 10:15:01 UTC
Size:
3.40 KB
patch
obsolete
>From cfb82a29c1ba4be331a772f110d606a059c03960 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 22 Jan 2013 15:08:41 -0500 >Subject: [PATCH] Bug 9450 [Revised] Use DataTables in cataloging Z39.50 > search results > >Replace the tablesorter plugin with the DataTables plugin in cataloging >Z39.50 search results. > >Structural changes were made to the table markup to deal with a >DataTables bug which prevents it from properly parsing a <th> with a >colspan. > >To test, go to cataloging and perform a Z39.50 search. Confirm that >table sorting works correctly. In this configuration there >should be no pager and no results filtering. > >Revision corrects template path to datatables assets. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Comment: Sorting works. No errors. >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > .../prog/en/modules/cataloguing/z3950_search.tt | 27 ++++++++++---------- > 1 file changed, 14 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >index 558f2ee..c30d23b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >@@ -3,7 +3,10 @@ > [% INCLUDE 'greybox.inc' %] > [% INCLUDE 'doc-head-close.inc' %] > <script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.checkboxes.min.js"></script> >-<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.tablesorter.min.js"></script> >+<link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> >+<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.dataTables.min.js"></script> >+[% INCLUDE 'datatables-strings.inc' %] >+<script type="text/javascript" src="[% themelang %]/js/datatables.js"></script> > <script type="text/javascript"> > //<![CDATA[ > function Import(GetThisOne,biblionumber) { >@@ -11,12 +14,6 @@ function Import(GetThisOne,biblionumber) { > window.close(); > return false; > } >-$.tablesorter.addParser({ >- id: 'articles', >- is: function(s) {return false; }, >- format: function(s) { return s.toLowerCase().replace(/^(the|an|a) /,''); }, >- type: 'text' >-}); > > function closemenu(){ > $(".linktools").hide(); >@@ -32,11 +29,14 @@ $(document).ready(function(){ > $(".checkboxed").unCheckCheckboxes(); > return false; > }); >- $("#resultst").tablesorter({ >- sortList: [[1,0]], >- headers: { 1: { sorter: 'articles' },7: { sorter: false },8: { sorter: false } }, >- widgets: ['zebra'] >- }); >+ $("#resultst").dataTable($.extend(true, {}, dataTablesDefaults, { >+ "sDom": 't', >+ "aoColumnDefs": [ >+ { "aTargets": [ -1,-2,-3 ], "bSortable": false, "bSearchable": false }, >+ ], >+ "aaSorting": [[ 1, "asc" ]], >+ "bPaginate": false >+ })); > /* Inline edit/delete links */ > $("td").click(function(event){ > var $tgt = $(event.target); >@@ -157,7 +157,8 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > <th>Edition</th> > <th>ISBN</th> > <th>LCCN</th> >- <th colspan="2">Preview</th> >+ <th>MARC</th> >+ <th>Card</th> > <th> </th> > </tr></thead> > <tbody>[% FOREACH breeding_loo IN breeding_loop %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9450
:
14761
|
14774
|
15085
|
15703
|
15747
| 15885