The cataloging Z39.50 search results window uses the old tablesorter plugin. It should use the DataTables plugin.
Created attachment 14761 [details] [review] Bug 9450 - Use DataTables in cataloging Z39.50 search results Replace the tablesorter plugin with the DataTables plugin in cataloging Z39.50 search results. Structural changes were made to the table markup to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, go to cataloging and perform a Z39.50 search. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering.
Created attachment 14774 [details] sort issue Owen, I don't know why this table is not sort correctly. Please see the screenshot.
(In reply to comment #2) > I don't know why this table is not sort correctly. I can't reproduce this problem. Is the problem only with that search, or with any? Is the problem only with title sort?
Created attachment 15085 [details] [review] Bug 9450 - Use DataTables in cataloging Z39.50 search results Replace the tablesorter plugin with the DataTables plugin in cataloging Z39.50 search results. Structural changes were made to the table markup to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, go to cataloging and perform a Z39.50 search. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
I've signed off on the patch after testing. I was able to reproduce the title sorting issue that Jonathan saw (connecting to z3950.bnf.fr/TOUT, character encoding ISO 5426), but that problem also existed with the old tablesorter plugin and, in fact, has nothing to do with either jQuery plugin -- the sorting is thrown off by embedded NSB/NSE characters in the title. That's worth opening a separate bug.
Created attachment 15703 [details] [review] Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results Replace the tablesorter plugin with the DataTables plugin in cataloging Z39.50 search results. Structural changes were made to the table markup to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, go to cataloging and perform a Z39.50 search. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets.
Created attachment 15747 [details] [review] [SIGNED-OFF] Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results Replace the tablesorter plugin with the DataTables plugin in cataloging Z39.50 search results. Structural changes were made to the table markup to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, go to cataloging and perform a Z39.50 search. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No errors.
QA comment: I got the sort issue but as Galen said it caused by the NSB/NSE characters (\x88Les \x89). I opened a new bug (bug 9747). Marked as Passed QA.
Created attachment 15885 [details] [review] Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results Replace the tablesorter plugin with the DataTables plugin in cataloging Z39.50 search results. Structural changes were made to the table markup to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, go to cataloging and perform a Z39.50 search. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.