Attachment 19220 Details for Bug 10504 – Bug 10504: Remove the unused C4::Acq::ModOrderItem routine

[patch] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine

Bug-10504-Remove-the-unused-C4AcqModOrderItem-rout.patch (text/plain), 2.27 KB, created by Jonathan Druart on 2013-06-25 07:15:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-06-25 07:15:25 UTC

Size: 2.27 KB

patch

obsolete

>From 83d44e8fc318459a1d3044bdb725216cc40840e3 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 25 Jun 2013 09:09:38 +0200
>Subject: [PATCH] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine
>
>This routine has been introduced by commit
>2d90fb22d43db986547bbaa945873d6dd78aab71.
>The only call has been removed by commit
>9eba7dc594fc0d4698da5e791d5f6f8682b2712a.
>
>So now, this routine is useless.
>
>Test plan:
>  - git grep ModOrderItem should return no result.
>---
> C4/Acquisition.pm       |   31 -------------------------------
> cataloguing/moveitem.pl |    2 +-
> 2 files changed, 1 insertion(+), 32 deletions(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index b6fab5d..36e5973 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -1257,37 +1257,6 @@ sub ModOrder {
> 
> #------------------------------------------------------------#
> 
>-=head3 ModOrderItem
>-
>-  &ModOrderItem(\%hashref);
>-
>-Modifies the itemnumber in the aqorders_items table. The input hash needs three entities:
>-
>-=over
>-
>-=item - itemnumber: the old itemnumber
>-=item - ordernumber: the order this item is attached to
>-=item - newitemnumber: the new itemnumber we want to attach the line to
>-
>-=back
>-
>-=cut
>-
>-sub ModOrderItem {
>-    my $orderiteminfo = shift;
>-    if (! $orderiteminfo->{'ordernumber'} || ! $orderiteminfo->{'itemnumber'} || ! $orderiteminfo->{'newitemnumber'}){
>-        die "Ordernumber, itemnumber and newitemnumber is required";
>-    }
>-
>-    my $dbh = C4::Context->dbh;
>-
>-    my $query = "UPDATE aqorders_items set itemnumber=? where itemnumber=? and ordernumber=?";
>-    my @params = ($orderiteminfo->{'newitemnumber'}, $orderiteminfo->{'itemnumber'}, $orderiteminfo->{'ordernumber'});
>-    my $sth = $dbh->prepare($query);
>-    $sth->execute(@params);
>-    return 0;
>-}
>-
> =head3 ModItemOrder
> 
>     ModItemOrder($itemnumber, $ordernumber);
>diff --git a/cataloguing/moveitem.pl b/cataloguing/moveitem.pl
>index 24414cc..2622c36 100755
>--- a/cataloguing/moveitem.pl
>+++ b/cataloguing/moveitem.pl
>@@ -30,7 +30,7 @@ use C4::Context;
> use C4::Koha;
> use C4::Branch;
> use C4::ClassSource;
>-use C4::Acquisition qw/GetOrderFromItemnumber ModOrder GetOrder ModOrderItem/;
>+use C4::Acquisition qw/GetOrderFromItemnumber ModOrder GetOrder/;
> 
> use Date::Calc qw(Today);
> 
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10504: 19220 | 19305 | 19537 | 19650 | 19652 | 19653