Created attachment 19220 [details] [review] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Test plan: - git grep ModOrderItem should return no result.
Comment on attachment 19220 [details] [review] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine Review of attachment 19220 [details] [review]: ----------------------------------------------------------------- C4/Acquistion.pm still is exporting ModOrderItem, so we need to clean that too. grep ModOrderItem -r * C4/Acquisition.pm: &NewOrderItem &ModOrderItem &ModItemOrder
Created attachment 19305 [details] [review] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Test plan: - git grep ModOrderItem should return no result.
Created attachment 19537 [details] [review] [SIGNED-OFF] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
koha-qa.pl gives this failure FAIL C4/Acquisition.pm FAIL pod *** WARNING: No items in =over / =back list in file C4/Acquisition.pm *** ERROR: Spurious text after =cut in file C4/Acquisition.pm I don't believe this is a result of your patch though. However, looking at the diff for your patch, I see file_not_specified_in_diff, which doesn't look like something we want to have in there!
Kyle, I cannot reproduce: $ git reset --hard origin/master $ git bz apply 10504 Bug 10504 - C4::Acquisition::ModOrderItem is unused 19537 - [SIGNED-OFF] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10504: Remove the unused C4::Acq::ModOrderItem routine $ qa -c 1 -v 2 testing 1 commit(s) (applied to 275f405 'Bug 10514: improve visibility of Add ') OK C4/Acquisition.pm OK pod OK forbidden patterns OK valid OK critic OK cataloguing/moveitem.pl OK pod OK forbidden patterns OK valid OK critic
Created attachment 19650 [details] [review] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Confirmed, I have no idea how I got that error. However, the more important issue to me is the file_not_specified_in_diff you can see looking here: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19650&action=diff
Created attachment 19652 [details] [review] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 19653 [details] [review] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Kyle, I edited the lines with the commit id's in the commit message. Now this display problem is gone. But this seems to not to worry git itself, just bugzilla..
Status back to Signed off ?
Excellent! Thanks!
I have no errors while running koha-qa.
Pushed to master. Thanks, Jonathan!
This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jonathan!
Pushed to 3.10.x, will be in 3.10.10