Bugzilla – Attachment 1996 Details for
Bug 4302
shouldn't have to scroll left to right on z search results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-4302-shouldn-t-have-to-scroll-left-to-ri.patch (text/plain), 6.09 KB, created by
Chris Cormack
on 2010-04-13 19:49:00 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2010-04-13 19:49:00 UTC
Size:
6.09 KB
patch
obsolete
>From 556e10e8dc42c6a4acec6cf6e8ee6122b8f6403b Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 13 Apr 2010 15:44:32 -0400 >Subject: [PATCH] Fix for Bug 4302, shouldn't have to scroll left to right on z search results > >Adds inline pop-up menu for each row of Z39.50 search results, similar to the >one recently added to the additem screen. This allows the user to click >anywhere in the row to display the menu and access the preview/import links. >--- > .../prog/en/includes/cataloging-toolbar.inc | 2 +- > .../prog/en/modules/cataloguing/z3950_search.tmpl | 46 ++++++++++++++++---- > 2 files changed, 38 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-toolbar.inc >index a555bab..d834de9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-toolbar.inc >@@ -39,7 +39,7 @@ > function PopupZ3950() { > var strQuery = GetZ3950Terms(); > if(strQuery){ >- window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber" -->"+strQuery,"z3950search",'width=740,height=450,location=yes,toolbar=no,scrollbars=yes,resize=yes'); >+ window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber" -->"+strQuery,"z3950search",'width=760,height=450,location=yes,toolbar=no,scrollbars=yes,resize=yes'); > } > } > /* provide Z3950 search points */ >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tmpl >index 5fbe223..55859c7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tmpl >@@ -18,6 +18,10 @@ $.tablesorter.addParser({ > type: 'text' > }); > >+function closemenu(){ >+ $(".linktools").hide(); >+ $("tr").removeClass("selected"); >+} > $(document).ready(function(){ > $("#CheckAll").click(function(){ > $(".checkboxed").checkCheckboxes(); >@@ -29,12 +33,35 @@ $(document).ready(function(){ > }); > $("#resultst").tablesorter({ > sortList: [[1,0]], >- headers: { 0: {sorter:false}, 1: { sorter: 'articles' },5: { sorter: false },6: { sorter: false } }, >+ headers: { 1: { sorter: 'articles' },7: { sorter: false },8: { sorter: false } }, > widgets: ['zebra'] > }); >+ /* Inline edit/delete links */ >+ $("td").click(function(event){ >+ $(".linktools").hide(); >+ $("tr").removeClass("selected"); >+ var row = $(this).parent(); >+ row.addClass("selected"); >+ >+ var $tgt = $(event.target); >+ if($tgt.is("a")||$tgt.is(":nth-child(7)")||$tgt.is(":nth-child(8)")||$tgt.is(":nth-child(9)")||$tgt.is(":nth-child(10)")){ return true; } else { >+ var position = $(this).offset(); >+ var top = position.top+5; >+ var left = position.left+5; >+ $(".linktools",row).show().css("position","absolute").css("top",top).css("left",left); >+ } >+ }); > }); >+ > //]]> > </script> >+<style type="text/css"> >+.linktools { background-color:#FFF;border-top:1px solid #DDD; border-left: 1px solid #DDD; border-right: 1px solid #666; border-bottom:1px solid #666;display: none; white-space: nowrap;} >+.linktools a { font-size : 85%; text-decoration:none; padding:.3em;;background-color:#FFF; display:block;float:left;border-right:1px solid #DDD;} >+.linktools a:hover { background-color:#EEE;color:#CC3300;border-right:1px solid #CCC;} >+tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : transparent; } >+</style> >+ <!-- TMPL_IF name="opsearch" --> > <style type="text/css"> > #custom-doc { width:53em;*width:51.72em;min-width:689px; margin:auto; text-align:left; } > </style> >@@ -42,6 +69,11 @@ $(document).ready(function(){ > <body> > > <div id="custom-doc" class="yui-t7"> >+<!-- TMPL_ELSE --> >+</head> >+<body style="padding:.5em;"> >+<div> >+<!-- /TMPL_IF --> > <div id="bd"> > <!-- TMPL_IF name="opsearch" --> > <h2>Z39.50 Search Points</h2> >@@ -103,13 +135,9 @@ $(document).ready(function(){ > </tr></thead> > <tbody><!-- TMPL_LOOP name="breeding_loop" --> > <!-- TMPL_IF NAME="breedingid" --> >- >- <!-- TMPL_UNLESS NAME="__odd__" --> >- <tr class="highlight"> >- <!-- TMPL_ELSE --> >- <tr> >- <!-- /TMPL_UNLESS --> >- <td><!-- TMPL_VAR name="server" --></td> >+ >+ <tr id="row<!-- TMPL_VAR NAME="breedingid" -->"> >+ <td><!-- TMPL_VAR name="server" --> <div class="linktools"><a href="/cgi-bin/koha/catalogue/showmarc.pl?importid=<!-- TMPL_VAR NAME="breedingid" -->" rel="gb_page_center[600,500]">Preview MARC</a> <a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&importid=<!-- TMPL_VAR NAME="breedingid" -->" rel="gb_page_center[600,500]">Preview Card</a> <a href="#" onclick="Import(<!-- TMPL_VAR NAME="breedingid" -->,0); return false">Import</a><a href="#" onclick="closemenu();return false;" title="Close this menu"> X </a></div> </td> > <td><!-- TMPL_VAR NAME="title" escape="html" --></td> > <td><!-- TMPL_VAR NAME="author" --></td> > <td><!-- TMPL_VAR NAME="date" --></td> >@@ -118,7 +146,7 @@ $(document).ready(function(){ > <td><!-- TMPL_VAR NAME="lccn" --></td> > <td><a href="/cgi-bin/koha/catalogue/showmarc.pl?importid=<!-- TMPL_VAR NAME="breedingid" -->" title="MARC" rel="gb_page_center[600,500]">MARC</a></td> > <td><a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&importid=<!-- TMPL_VAR NAME="breedingid" -->" title="MARC" rel="gb_page_center[600,500]">Card</a></td> >- <td><a href="javascript:Import(<!-- TMPL_VAR NAME="breedingid" -->,<!-- TMPL_VAR NAME="biblionumber" -->)">Import</a></td> >+ <td><a href="#" onclick="Import(<!-- TMPL_VAR NAME="breedingid" -->,<!-- TMPL_VAR NAME="biblionumber" -->); return false">Import</a></td> > </tr> > <!-- /TMPL_IF --> > <!-- /TMPL_LOOP --></tbody> >-- >1.6.3.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4302
:
1995
| 1996