Bug 4302 - shouldn't have to scroll left to right on z search results
Summary: shouldn't have to scroll left to right on z search results
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-05 02:49 UTC by Nicole C. Engard
Modified: 2012-10-25 23:04 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot after proposed change (10.57 KB, image/png)
2010-03-05 15:09 UTC, Chris Cormack
Details
Proposed fix (6.09 KB, patch)
2010-04-13 19:49 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:25:34 UTC


---- Reported by nengard@gmail.com 2010-03-05 14:49:31 ----

When z39.50 search results are returned the results do not conform to the window size and so I have to scroll left to right to see the title and then the import link and then back to the title if it's the wrong one - making it hard to import the right record - plus having a left to right scroll bar is just bad :)



---- Additional Comments From oleonard@myacpl.org 2010-03-05 15:09:40 ----

Created an attachment
Screenshot after proposed change

As it happens I've been working on this issue for the last couple of days. Attached is the solution I propose. It uses an in-table pop-up menu similar to the one recently added to the add item screen.

It's not possible to force the table to fit within the window: in the example pictured in the attachment the horizontal scrollbar didn't disappear until the window was over 1000x900 pixels. The cause is usually the concatenated ISBN data:

9789004161801(hardback:alkpaper)|9004161805(hardback:alkpaper)

...which doesn't allow any line breaks. My solution doesn't eliminate the horizontal scrollbar but at least it reduces the necessity of scrolling.



---- Additional Comments From nengard@gmail.com 2010-03-05 17:37:48 ----

I love it!!! 



---- Additional Comments From jwagner@ptfs.com 2010-03-05 19:57:47 ----

I did some modifications on this page for one of my sites, but Owen's solution is more elegant.  I did a brute-force change to a full screen, and also moved the Preview/Import/etc. column to earlier in the table.




---- Additional Comments From oleonard@myacpl.org 2010-04-13 19:49:26 ----

Created an attachment
Proposed fix

Adds inline pop-up menu for each row of Z39.50 search results, similar to the
one recently added to the additem screen. This allows the user to click
anywhere in the row to display the menu and access the preview/import links.



---- Additional Comments From gmcharlt@gmail.com 2010-04-23 11:11:06 ----

Patch pushed.  Please test and close.



---- Additional Comments From nengard@gmail.com 2010-04-23 12:44:27 ----

The patch works, but if there is a way to eliminate the scroll bar that would actually fix this bug ... not sure if it should be closed since the original issue isn't resolved.



---- Additional Comments From oleonard@myacpl.org 2010-04-30 19:37:48 ----

If someone else would like to take over this bug I think the next step would be to add some processing to the script to replace the "|" in the ISBN string with a space so that field could break onto multiple lines. I think that's the only way to approach "fixed" here.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:25 UTC  ---

This bug was previously known as _bug_ 4302 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4302
Imported an attachment (id=1995)
Imported an attachment (id=1996)

Actual time not defined. Setting to 0.0
CC member jwagner@ptfs.com does not have an account here
The original submitter of attachment 1995 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1996 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.