Bugzilla – Attachment 23818 Details for
Bug 10453
updating child to adult loses password
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10453: Updating child to adult loses password
PASSED-QA-Bug-10453-Updating-child-to-adult-loses-.patch (text/plain), 1.45 KB, created by
Katrin Fischer
on 2013-12-26 10:51:18 UTC
(
hide
)
Description:
[PASSED QA] Bug 10453: Updating child to adult loses password
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-12-26 10:51:18 UTC
Size:
1.45 KB
patch
obsolete
>From 319d502e88af700992914a9d46098c81e78ac934 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 24 Dec 2013 14:35:36 +0100 >Subject: [PATCH] [PASSED QA] Bug 10453: Updating child to adult loses password > >ModMember supposes the password given in parameter is the >password string, so if it receives the encrypted password, >it will encrypt it again! By simply deleting the password key >from the hash, ModMember leaves the password unchanged. > >Test plan: >1/ Create or choose a child patron >2/ Update it to an adult category using the > "Update child to adult patron" link >3/ Try to log in at the OPAC with this patron: It is not > possible, the password has changed >4/ Apply the patch and try again previous steps > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Confirmed the problem and tested the patch fixes it. >Passes all tests and QA script. >--- > members/update-child.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/members/update-child.pl b/members/update-child.pl >index 492219f..6e7b1da 100755 >--- a/members/update-child.pl >+++ b/members/update-child.pl >@@ -86,6 +86,7 @@ elsif ( $op eq 'update' ) { > my $borcat = GetBorrowercategory($catcode); > $member->{'category_type'} = $borcat->{'category_type'}; > $member->{'description'} = $borcat->{'description'}; >+ delete $member->{password}; > ModMember(%$member); > > if ( $catcode_multi ) { >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10453
:
23809
|
23810
| 23818