Bug 10453 - updating child to adult loses password
Summary: updating child to adult loses password
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low critical (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-12 14:40 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10453: Updating child to adult loses password (1.16 KB, patch)
2013-12-24 13:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED OFF] Bug 10453: Updating child to adult loses password (1.32 KB, patch)
2013-12-24 14:44 UTC, Mark Tompsett
Details | Diff | Splinter Review
[PASSED QA] Bug 10453: Updating child to adult loses password (1.45 KB, patch)
2013-12-26 10:51 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2013-06-12 14:40:22 UTC
Tested in 3.10.x and master.

When you update a child to an adult it loses the password (or changes it) - the patron can no longer log in to the OPAC after using the 'update child to adult' in the staff client.
Comment 1 Jonathan Druart 2013-12-24 13:41:35 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2013-12-24 14:44:54 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2013-12-24 14:46:03 UTC
Merry Christmas! :)
Comment 4 Katrin Fischer 2013-12-26 10:51:18 UTC
Created attachment 23818 [details] [review]
[PASSED QA] Bug 10453: Updating child to adult loses password

ModMember supposes the password given in parameter is the
password string, so if it receives the encrypted password,
it will encrypt it again! By simply deleting the password key
from the hash, ModMember leaves the password unchanged.

Test plan:
1/ Create or choose a child patron
2/ Update it to an adult category using the
   "Update child to adult patron" link
3/ Try to log in at the OPAC with this patron: It is not
   possible, the password has changed
4/ Apply the patch and try again previous steps

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Confirmed the problem and tested the patch fixes it.
Passes all tests and QA script.
Comment 5 Galen Charlton 2013-12-26 15:31:37 UTC
Pushed to master.  Thanks, Jonathan!
Comment 6 Fridolin Somers 2014-01-14 08:35:44 UTC
Patch pushed to 3.14.x, will be in 3.14.2.
Comment 7 Tomás Cohen Arazi 2014-02-07 14:58:36 UTC
This patch has been pushed to 3.12.x, will be in 3.12.11.

Thanks Jonathan!