Attachment 24290 Details for Bug 11555 – Bug 11555 - Make "All" one of the default options for datatables

[patch] Bug 11555 - Make "All" one of the default options for datatables

Bug-11555---Make-All-one-of-the-default-options-fo.patch (text/plain), 2.92 KB, created by Kyle M Hall (khall) on 2014-01-14 15:42:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-01-14 15:42:05 UTC

Size: 2.92 KB

patch

obsolete

>From d0b2369d5aad66af6b9ac987fbb9a09fab7c3f4a Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 14 Jan 2014 10:37:09 -0500
>Subject: [PATCH] Bug 11555 - Make "All" one of the default options for datatables
>
>There are many instances where librarians would like to have the ability
>to see all the rows in a datatable at one. It seems prudent to make this
>a default option for datatables, rather than change it on a case by case
>basis.
>
>Test Plan:
>1) View the circulation history for a patron
>2) Note you can select to view 10, 25, 50, or 100 entries
>3) Apply this patch
>4) Reload the circulation history page for a patron
>5) Note the new "All" option
>6) Verify the "All" option shows all the rows at once
>---
> .../prog/en/includes/datatables-strings.inc        |    1 +
> .../intranet-tmpl/prog/en/includes/datatables.inc  |    3 ++-
> koha-tmpl/intranet-tmpl/prog/en/js/datatables.js   |    3 ++-
> 3 files changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/datatables-strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/datatables-strings.inc
>index 7e939fc..ead071b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/datatables-strings.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/datatables-strings.inc
>@@ -13,6 +13,7 @@
>     var MSG_DT_PROCESSING = _("Processing...");
>     var MSG_DT_SEARCH = _("Search:");
>     var MSG_DT_ZERO_RECORDS = _("No matching records found");
>+    var MSG_DT_ALL = _("All");
>     var CONFIG_EXCLUDE_ARTICLES_FROM_SORT = _("a an the");
> //]]>
> </script>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
>index 703d1e3..44d8277 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
>@@ -14,7 +14,8 @@
>     var MSG_DT_PROCESSING = _("Processing...");
>     var MSG_DT_SEARCH = _("Search:");
>     var MSG_DT_ZERO_RECORDS = _("No matching records found");
>+    var MSG_DT_ALL = _("All");
>     var CONFIG_EXCLUDE_ARTICLES_FROM_SORT = _("a an the");
> //]]>
> </script>
>-<script type="text/javascript" src="[% themelang %]/js/datatables.js"></script>
>\ No newline at end of file
>+<script type="text/javascript" src="[% themelang %]/js/datatables.js"></script>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js
>index c2a2cf8..cc809c1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js
>@@ -23,7 +23,8 @@ var dataTablesDefaults = {
>         "sSearch"           : window.MSG_DT_SEARCH || "Search:",
>         "sZeroRecords"      : window.MSG_DT_ZERO_RECORDS || "No matching records found"
>     },
>-    "sDom": '<"top pager"ilpf>t<"bottom pager"ip>'
>+    "sDom": '<"top pager"ilpf>t<"bottom pager"ip>',
>+    "aLengthMenu": [[10, 25, 50, 100, -1], [10, 25, 50, 100, window.MSG_DT_ALL || "All"]]
> };
> 
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11555: 24290 | 24670 | 24671