There are many instances where librarians would like to have the ability to see all the rows in a datatable at one. It seems prudent to make this a default option for datatables, rather than change it on a case by case basis.
Created attachment 24290 [details] [review] Bug 11555 - Make "All" one of the default options for datatables There are many instances where librarians would like to have the ability to see all the rows in a datatable at one. It seems prudent to make this a default option for datatables, rather than change it on a case by case basis. Test Plan: 1) View the circulation history for a patron 2) Note you can select to view 10, 25, 50, or 100 entries 3) Apply this patch 4) Reload the circulation history page for a patron 5) Note the new "All" option 6) Verify the "All" option shows all the rows at once
Sorry if I did this wrong; long time listener -- first time caller. This patch has been applied to our production server at SEKLS and works as expected.
Created attachment 24670 [details] [review] Bug 11555 - Make "All" one of the default options for datatables There are many instances where librarians would like to have the ability to see all the rows in a datatable at one. It seems prudent to make this a default option for datatables, rather than change it on a case by case basis. Test Plan: 1) View the circulation history for a patron 2) Note you can select to view 10, 25, 50, or 100 entries 3) Apply this patch 4) Reload the circulation history page for a patron 5) Note the new "All" option 6) Verify the "All" option shows all the rows at once Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I tested the translation for "All"
Created attachment 24671 [details] [review] Bug 11555: The menu entries are 10, 20, 50, 100, -1 If you have a look at git grep aLengthMenu, you will see we choose 20 instead of 25. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(In reply to Jason Robb from comment #2) > Sorry if I did this wrong; long time listener -- first time caller. > > This patch has been applied to our production server at SEKLS and works as > expected. Yes but your production server is certainly not using a master branch :) So the patch could be work on it but not against the master branch.
I submitted a followup on bug 11605.
Pushed to master. Thanks, Kyle!
Pushed to 3.14.x, will be in 3.14.08