Bug 11555 - Make "All" one of the default options for datatables
Summary: Make "All" one of the default options for datatables
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks: 11605
  Show dependency treegraph
 
Reported: 2014-01-14 15:35 UTC by Kyle M Hall
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11555 - Make "All" one of the default options for datatables (2.92 KB, patch)
2014-01-14 15:42 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11555 - Make "All" one of the default options for datatables (3.06 KB, patch)
2014-01-24 11:08 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11555: The menu entries are 10, 20, 50, 100, -1 (1.12 KB, patch)
2014-01-24 11:12 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-01-14 15:35:42 UTC
There are many instances where librarians would like to have the ability to see all the rows in a datatable at one. It seems prudent to make this a default option for datatables, rather than change it on a case by case basis.
Comment 1 Kyle M Hall 2014-01-14 15:42:05 UTC Comment hidden (obsolete)
Comment 2 Jason Robb 2014-01-22 22:33:01 UTC
Sorry if I did this wrong; long time listener -- first time caller.

This patch has been applied to our production server at SEKLS and works as expected.
Comment 3 Jonathan Druart 2014-01-24 11:08:40 UTC
Created attachment 24670 [details] [review]
Bug 11555 - Make "All" one of the default options for datatables

There are many instances where librarians would like to have the ability
to see all the rows in a datatable at one. It seems prudent to make this
a default option for datatables, rather than change it on a case by case
basis.

Test Plan:
1) View the circulation history for a patron
2) Note you can select to view 10, 25, 50, or 100 entries
3) Apply this patch
4) Reload the circulation history page for a patron
5) Note the new "All" option
6) Verify the "All" option shows all the rows at once

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I tested the translation for "All"
Comment 4 Jonathan Druart 2014-01-24 11:12:44 UTC
Created attachment 24671 [details] [review]
Bug 11555: The menu entries are 10, 20, 50, 100, -1

If you have a look at git grep aLengthMenu, you will see we choose 20
instead of 25.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2014-01-24 11:14:09 UTC
(In reply to Jason Robb from comment #2)
> Sorry if I did this wrong; long time listener -- first time caller.
> 
> This patch has been applied to our production server at SEKLS and works as
> expected.

Yes but your production server is certainly not using a master branch :)
So the patch could be work on it but not against the master branch.
Comment 6 Jonathan Druart 2014-01-24 11:20:44 UTC
I submitted a followup on bug 11605.
Comment 7 Galen Charlton 2014-03-10 19:08:00 UTC
Pushed to master.  Thanks, Kyle!
Comment 8 Fridolin Somers 2014-06-04 08:22:42 UTC
Pushed to 3.14.x, will be in 3.14.08