Bugzilla – Attachment 26325 Details for
Bug 11637
No way to prevent a prediction date for the next issue in serials
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11637: Irregular subscriptions don't know when serials are planned
PASSED-QA-Bug-11637-Irregular-subscriptions-dont-k.patch (text/plain), 2.51 KB, created by
Katrin Fischer
on 2014-03-14 08:18:50 UTC
(
hide
)
Description:
[PASSED QA] Bug 11637: Irregular subscriptions don't know when serials are planned
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-03-14 08:18:50 UTC
Size:
2.51 KB
patch
obsolete
>From ad5301d96247d53150218b60dc8d8eacdf12d8e9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 21 Feb 2014 17:16:43 +0100 >Subject: [PATCH] [PASSED QA] Bug 11637: Irregular subscriptions don't know > when serials are planned > >Test plan: >Create a subscription with an irregular numbering pattern. > >Verify the prediction pattern. With this patch, it should show "unknown" >instead of the date of the first issue publication date. > >This patch does not fix the issue on generating the next serial. > >http://bugs.koha-community.org/show_bug.cgi?id=11814 >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >This is a partial fix for a small regression in the serials module. >Now the prediction pattern doesn't predict dates when you test it, >and shows 'Unknown' instead. > >We still need to fix the 'planned date' set for the expected serial. >There should be no date, it should also be 'unknown'. > >Passes tests and QA script. >--- > serials/showpredictionpattern.pl | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > >diff --git a/serials/showpredictionpattern.pl b/serials/showpredictionpattern.pl >index 690705d..c654f55 100755 >--- a/serials/showpredictionpattern.pl >+++ b/serials/showpredictionpattern.pl >@@ -55,6 +55,7 @@ my $subtype = $input->param('subtype'); > my $sublength = $input->param('sublength'); > my $custompattern = $input->param('custompattern'); > >+my $frequency = GetSubscriptionFrequency($frequencyid); > > my %pattern = ( > numberingmethod => $input->param('numberingmethod') // '', >@@ -118,7 +119,7 @@ my @predictions_loop; > my ($calculated) = GetSeq(\%subscription, \%pattern); > push @predictions_loop, { > number => $calculated, >- publicationdate => $date, >+ publicationdate => ($frequency->{unit} ? $date : undef), > issuenumber => $issuenumber, > dow => Day_of_Week(split /-/, $date), > }; >@@ -142,7 +143,7 @@ while( $i < 1000 ) { > $date = GetNextDate(\%subscription, $date); > } > if(defined $date){ >- $line{'publicationdate'} = $date; >+ $line{'publicationdate'} = $date if $frequency->{unit}; > $line{'dow'} = Day_of_Week(split /-/, $date); > } > >@@ -177,8 +178,6 @@ $template->param( > predictions_loop => \@predictions_loop, > ); > >-my $frequency = GetSubscriptionFrequency($frequencyid); >- > if ( $frequency->{unit} and not $custompattern ) { > $template->param( ask_for_irregularities => 1 ); > if ( $frequency->{unit} eq 'day' and $frequency->{unitsperissue} == 1 ) { >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11637
:
24873
|
25545
|
25728
| 26325