This needs more testing, but I think we have lost a feature in serials: It used to be possible to create a frequency/prediction pattern where no date was created for the next issue. Instead it would show XXX in some places. That was for serials where you had no idea about when the next isssue would arrive. It doesn't seem to be possible now in serials to do that. When testing an irregular pattern, for all issues today's date is shown and there is also always a date set for the next predicted issue. Maybe I am missing something - please comment :)
I confirm. Now, irregular patterns show the first issue publication date for each issue in the prediction pattern. Before, Koha used to display XXX instead, which was maybe more handy since one cant predict the issue dates with irregular patterns... See attachment "irregular_pattern.png" for an example.
Created attachment 24873 [details] Irregular pattern example
Created attachment 25545 [details] [review] Bug 11637: Irregular subscriptions don't know when serials are planned Test plan: Create a subscription with an irregular numbering pattern. Verify the prediction pattern. With this patch, it should show "unknown" instead of the date of the first issue publication date. This patch does not fix the issue on generating the next serial.
Created attachment 25728 [details] [review] Bug 11637: Irregular subscriptions don't know when serials are planned Test plan: Create a subscription with an irregular numbering pattern. Verify the prediction pattern. With this patch, it should show "unknown" instead of the date of the first issue publication date. This patch does not fix the issue on generating the next serial. http://bugs.koha-community.org/show_bug.cgi?id=11814 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 26325 [details] [review] [PASSED QA] Bug 11637: Irregular subscriptions don't know when serials are planned Test plan: Create a subscription with an irregular numbering pattern. Verify the prediction pattern. With this patch, it should show "unknown" instead of the date of the first issue publication date. This patch does not fix the issue on generating the next serial. http://bugs.koha-community.org/show_bug.cgi?id=11814 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This is a partial fix for a small regression in the serials module. Now the prediction pattern doesn't predict dates when you test it, and shows 'Unknown' instead. We still need to fix the 'planned date' set for the expected serial. There should be no date, it should also be 'unknown'. Passes tests and QA script.
Should I file a new bug for the 'planned date' in the issue itself?
(In reply to Katrin Fischer from comment #6) > Should I file a new bug for the 'planned date' in the issue itself? Yes
Pushed to master. Thanks, Jonathan!
Done - bug 12003
Pushed to 3.14.x, will be in 3.14.08