Bug 11637 - No way to prevent a prediction date for the next issue in serials
Summary: No way to prevent a prediction date for the next issue in serials
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 7688
Blocks: 11576 12003
  Show dependency treegraph
 
Reported: 2014-01-29 20:50 UTC by Katrin Fischer
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Irregular pattern example (59.35 KB, image/png)
2014-01-29 21:13 UTC, Francois Charbonnier
Details
Bug 11637: Irregular subscriptions don't know when serials are planned (2.08 KB, patch)
2014-02-21 16:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11637: Irregular subscriptions don't know when serials are planned (2.13 KB, patch)
2014-02-28 16:38 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 11637: Irregular subscriptions don't know when serials are planned (2.51 KB, patch)
2014-03-14 08:18 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-01-29 20:50:12 UTC
This needs more testing, but I think we have lost a feature in serials: 

It used to be possible to create a frequency/prediction pattern where no date was created for the next issue. Instead it would show XXX in some places. That was for serials where you had no idea about when the next isssue would arrive. It doesn't seem to be possible now in serials to do that. When testing an irregular pattern, for all issues today's date is shown and there is also always a date set for the next predicted issue.

Maybe I am missing something - please comment :)
Comment 1 Francois Charbonnier 2014-01-29 21:12:40 UTC
I confirm. Now, irregular patterns show the first issue publication date for each issue in the prediction pattern. 

Before, Koha used to display XXX instead, which was maybe more handy since one cant predict the issue dates with irregular patterns...

See attachment "irregular_pattern.png" for an example.
Comment 2 Francois Charbonnier 2014-01-29 21:13:15 UTC
Created attachment 24873 [details]
Irregular pattern example
Comment 3 Jonathan Druart 2014-02-21 16:24:07 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2014-02-28 16:38:57 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-03-14 08:18:50 UTC
Created attachment 26325 [details] [review]
[PASSED QA] Bug 11637: Irregular subscriptions don't know when serials are planned

Test plan:
Create a subscription with an irregular numbering pattern.

Verify the prediction pattern. With this patch, it should show "unknown"
instead of the date of the first issue publication date.

This patch does not fix the issue on generating the next serial.

http://bugs.koha-community.org/show_bug.cgi?id=11814
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This is a partial fix for a small regression in the serials module.
Now the prediction pattern doesn't predict dates when you test it,
and shows 'Unknown' instead.

We still need to fix the 'planned date' set for the expected serial.
There should be no date, it should also be 'unknown'.

Passes tests and QA script.
Comment 6 Katrin Fischer 2014-03-14 08:19:13 UTC
Should I file a new bug for the 'planned date' in the issue itself?
Comment 7 Galen Charlton 2014-03-14 15:16:22 UTC
(In reply to Katrin Fischer from comment #6)
> Should I file a new bug for the 'planned date' in the issue itself?

Yes
Comment 8 Galen Charlton 2014-03-14 15:19:55 UTC
Pushed to master.  Thanks, Jonathan!
Comment 9 Katrin Fischer 2014-03-26 21:37:55 UTC
Done - bug 12003
Comment 10 Fridolin Somers 2014-06-12 08:52:56 UTC
Pushed to 3.14.x, will be in 3.14.08