Bugzilla – Attachment 26435 Details for
Bug 11855
Tiny code cleanup in members
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11855: Tiny code cleanup in members
Bug-11855-Tiny-code-cleanup-in-members.patch (text/plain), 1.96 KB, created by
Jonathan Druart
on 2014-03-18 15:11:03 UTC
(
hide
)
Description:
Bug 11855: Tiny code cleanup in members
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-03-18 15:11:03 UTC
Size:
1.96 KB
patch
obsolete
>From e6b08e5f44a96e9c5f307a419b43e49aa00797e7 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 27 Feb 2014 09:12:25 +0100 >Subject: [PATCH] Bug 11855: Tiny code cleanup in members >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >[1] Template var actionname is not used in the associated template. This >could be a copy-paste from serials/member-search.pl. Consequently, the module >is no longer needed in member.pl. Template members/search.tt still contains >actionname; it seems that this template is not used too (but I did not fully >check that; so leaving that for now). > >[2] $template_name not used in members-home.pl. > >Test plan: >[1] Go to Patrons. If you reach that page, you tested members-home.pl >[2] Add a new patron. >[3] Search for a patron. Edit one. > >Followed test plan. No problems found. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > members/member.pl | 2 -- > members/members-home.pl | 1 - > 2 files changed, 3 deletions(-) > >diff --git a/members/member.pl b/members/member.pl >index ff6e41a..dfc7363 100755 >--- a/members/member.pl >+++ b/members/member.pl >@@ -31,7 +31,6 @@ use C4::Members; > use C4::Branch; > use C4::Category; > use Koha::DateUtils; >-use File::Basename; > use Koha::List::Patron; > > my $input = new CGI; >@@ -225,7 +224,6 @@ $template->param( > branchloop => \@branchloop, > categories => \@categories, > searching => "1", >- actionname => basename($0), > numresults => $count, > resultsloop => \@resultsdata, > results_per_page => $resultsperpage, >diff --git a/members/members-home.pl b/members/members-home.pl >index 1d8f1e5..9d1e3e5 100755 >--- a/members/members-home.pl >+++ b/members/members-home.pl >@@ -30,7 +30,6 @@ use Koha::Borrower::Modifications; > > my $query = new CGI; > my $branch = $query->param('branchcode'); >-my $template_name; > > $branch = q{} unless defined $branch; > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11855
:
25685
|
25716
| 26435 |
26436