Bug 11855 - Tiny code cleanup in members
Summary: Tiny code cleanup in members
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-27 07:44 UTC by Marcel de Rooy
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11855: Tiny code cleanup in members (1.78 KB, patch)
2014-02-27 08:21 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[Signed-off] Bug 11855: Tiny code cleanup in members (1.91 KB, patch)
2014-02-28 09:29 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 11855: Tiny code cleanup in members (1.96 KB, patch)
2014-03-18 15:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11855: remove unused template file (2.20 KB, patch)
2014-03-18 15:11 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2014-02-27 07:44:19 UTC

    
Comment 1 Marcel de Rooy 2014-02-27 08:21:42 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-02-28 09:29:49 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-03-18 15:11:03 UTC
Created attachment 26435 [details] [review]
Bug 11855: Tiny code cleanup in members

[1] Template var actionname is not used in the associated template. This
could be a copy-paste from serials/member-search.pl. Consequently, the module
is no longer needed in member.pl. Template members/search.tt still contains
actionname; it seems that this template is not used too (but I did not fully
check that; so leaving that for now).

[2] $template_name not used in members-home.pl.

Test plan:
[1] Go to Patrons. If you reach that page, you tested members-home.pl
[2] Add a new patron.
[3] Search for a patron. Edit one.

Followed test plan. No problems found.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jonathan Druart 2014-03-18 15:11:09 UTC
Created attachment 26436 [details] [review]
Bug 11855: remove unused template file

members/search.tt seems not to be in use anymore.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2014-03-18 15:13:23 UTC
(In reply to M. de Rooy from comment #1)
> Template members/search.tt still contains
> actionname; it seems that this template is not used too (but I did not fully
> check that; so leaving that for now).

It looks useless, I submitted a followup to remove the template file.
Galen, feel free not to push it if you have a doubt.

Marked as Passed QA.
Comment 6 Galen Charlton 2014-04-08 23:46:42 UTC
Pushed to master.  Thanks, Marcel and Jonathan!
Comment 7 Fridolin Somers 2014-07-23 15:59:37 UTC
Pushed to 3.14.x, will be in 3.14.09