Created attachment 25685 [details] [review] Bug 11855: Tiny code cleanup in members [1] Template var actionname is not used in the associated template. This could be a copy-paste from serials/member-search.pl. Consequently, the module is no longer needed in member.pl. Template members/search.tt still contains actionname; it seems that this template is not used too (but I did not fully check that; so leaving that for now). [2] $template_name not used in members-home.pl. Test plan: [1] Go to Patrons. If you reach that page, you tested members-home.pl [2] Add a new patron. [3] Search for a patron. Edit one.
Created attachment 25716 [details] [review] [Signed-off] Bug 11855: Tiny code cleanup in members [1] Template var actionname is not used in the associated template. This could be a copy-paste from serials/member-search.pl. Consequently, the module is no longer needed in member.pl. Template members/search.tt still contains actionname; it seems that this template is not used too (but I did not fully check that; so leaving that for now). [2] $template_name not used in members-home.pl. Test plan: [1] Go to Patrons. If you reach that page, you tested members-home.pl [2] Add a new patron. [3] Search for a patron. Edit one. Followed test plan. No problems found. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 26435 [details] [review] Bug 11855: Tiny code cleanup in members [1] Template var actionname is not used in the associated template. This could be a copy-paste from serials/member-search.pl. Consequently, the module is no longer needed in member.pl. Template members/search.tt still contains actionname; it seems that this template is not used too (but I did not fully check that; so leaving that for now). [2] $template_name not used in members-home.pl. Test plan: [1] Go to Patrons. If you reach that page, you tested members-home.pl [2] Add a new patron. [3] Search for a patron. Edit one. Followed test plan. No problems found. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 26436 [details] [review] Bug 11855: remove unused template file members/search.tt seems not to be in use anymore. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(In reply to M. de Rooy from comment #1) > Template members/search.tt still contains > actionname; it seems that this template is not used too (but I did not fully > check that; so leaving that for now). It looks useless, I submitted a followup to remove the template file. Galen, feel free not to push it if you have a doubt. Marked as Passed QA.
Pushed to master. Thanks, Marcel and Jonathan!
Pushed to 3.14.x, will be in 3.14.09