Attachment 27071 Details for Bug 12042 – [SIGNED OFF] Bug 12042 - Change text 'Add to basket' into 'Add order to basket'

[patch] [SIGNED OFF] Bug 12042 - Change text 'Add to basket' into 'Add order to basket'

Bug-12042---Change-text-Add-to-basket-into-Add-ord.patch (text/plain), 4.32 KB, created by Mark Tompsett on 2014-04-14 04:53:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2014-04-14 04:53:07 UTC

Size: 4.32 KB

patch

obsolete

>From dbe91346871a20e1ed97aafddc0b50e30e29f6d4 Mon Sep 17 00:00:00 2001
>From: Silvia Simonetti <s.simonetti@cineca.it>
>Date: Mon, 7 Apr 2014 13:44:38 +0200
>Subject: [PATCH] Bug 12042 - Change text 'Add to basket' into 'Add order to
> basket'
>
>It would be a good idea to clarify better the function of the
>"add to basket" button on the vendor search results page and on
>the single basket page. To make that, I suggest to add the word
>'order'. So, 'add to basket' would become 'add order to basket'.
>
>This is completely based on a cut-paste and git am of work done
>by Silvia Simonetti.
>
>TEST PLAN
>---------
>1) Log in to the staff client
>2) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/booksellers.pl
>   -- It should say 'add to basket'.
>3) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/basket.pl?basketno=1
>   -- Assuming you have a basketno=1, it should say 'add to basket'.
>4) Apply patch
>5) Repeat steps 2 and 3.
>   -- They should both have 'add order to basket' now.
>6) Run koha qa test tools
>   -- The problems mentioned on "221" are not related to this patch.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>NOTE: I generated the proper patch.
>      And wrote the test plan more clearly.
>      This patch does what it says it will do. However,
>      I am not sure the rewording is best. Consider that the
>      button on the basket page triggers a modal similar to the
>      section at the bottom of the page. That is, is the button
>      even necessary? Though, the rename of the button now will
>      match the section header 'Add order to basket'. I leave
>      the design decisions to someone else.
>---
> .../intranet-tmpl/prog/en/modules/acqui/basket.tt  |    2 +-
> .../prog/en/modules/acqui/booksellers.tt           |    2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index cd31176..6c7de92 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -178,7 +178,7 @@
>         [% UNLESS ( selectbasketg ) %]
>             [% UNLESS ( closedate ) %]
>                 <div id="toolbar" class="btn-toolbar">
>-                    <div class="btn-group"><a href="#addtoBasket" role="button" class="btn btn-small" data-toggle="modal"><i class="icon-plus"></i> Add to basket</a></div>
>+                    <div class="btn-group"><a href="#addtoBasket" role="button" class="btn btn-small" data-toggle="modal"><i class="icon-plus"></i> Add order to basket</a></div>
>                     <div class="btn-group"><a href="basketheader.pl?booksellerid=[% booksellerid %]&amp;basketno=[% basketno %]&amp;op=add_form" class="btn btn-small" id="basketheadbutton"><i class="icon-pencil"></i> Edit basket</a></div>
>                     <div class="btn-group"><a href="#deleteBasketModal" role="button" class="btn btn-small" data-toggle="modal" id="delbasketbutton"><i class="icon-remove"></i> Delete this basket</a></div>
>                    [% IF ( unclosable ) %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>index 3fa12e2..fd4e52a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>@@ -145,7 +145,7 @@ $(document).ready(function() {
>                                             <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basket.basketno %]">View</a>
> 
>                                             [% UNLESS ( basket.closedate ) %]
>-                                               | <a id="addtoBasketLabel[% basket.basketno %]" href="#addtoBasket[% basket.basketno %]" role="button" data-toggle="modal">Add to basket</a>
>+                                               | <a id="addtoBasketLabel[% basket.basketno %]" href="#addtoBasket[% basket.basketno %]" role="button" data-toggle="modal">Add order to basket</a>
>                                                 
>                                                 <div id="addtoBasket[% basket.basketno %]" class="modal hide" tabindex="-1" role="dialog" aria-labelledby="addtoBasketLabel[% basket.basketno %]" aria-hidden="true" data-basketno="[% basket.basketname %]">
>                                                     <div class="modal-body">
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 12042: 26892 | 26893 | 27070 | 27071