Bug 12042 - Change text ‘Add to basket’ into ‘Add order to basket’
Summary: Change text ‘Add to basket’ into ‘Add order to basket’
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Silvia Simonetti
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-08 09:21 UTC by Silvia Simonetti
Modified: 2015-12-03 22:00 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Change text ‘Add to basket’ into ‘Add order to basket’ (1.01 KB, application/x-gzip)
2014-04-08 09:49 UTC, Silvia Simonetti
Details
patch for this bug (3.19 KB, text/plain)
2014-04-08 09:53 UTC, Silvia Simonetti
Details
Bug 12042 - Change text 'Add to basket' into 'Add order to basket' (2.98 KB, patch)
2014-04-14 04:38 UTC, Mark Tompsett
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12042 - Change text 'Add to basket' into 'Add order to basket' (4.32 KB, patch)
2014-04-14 04:53 UTC, Mark Tompsett
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Silvia Simonetti 2014-04-08 09:21:16 UTC
I think it would be a good idea to clarify better the function of the 
"add to basket" button on the vendor search results page    
/cgi-bin/koha/acqui/booksellers.pl
and on the single basket page  
cgi-bin/koha/acqui/basket.pl?basketno=1.
To make that, I suggest to add the word order. So  "add to basket" could become ‘add order to basket’
Comment 1 Silvia Simonetti 2014-04-08 09:49:07 UTC Comment hidden (obsolete)
Comment 2 Silvia Simonetti 2014-04-08 09:53:06 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2014-04-14 04:38:23 UTC Comment hidden (obsolete)
Comment 4 Mark Tompsett 2014-04-14 04:53:07 UTC
Created attachment 27071 [details] [review]
[SIGNED OFF] Bug 12042 - Change text 'Add to basket' into 'Add order to basket'

It would be a good idea to clarify better the function of the
"add to basket" button on the vendor search results page and on
the single basket page. To make that, I suggest to add the word
'order'. So, 'add to basket' would become 'add order to basket'.

This is completely based on a cut-paste and git am of work done
by Silvia Simonetti.

TEST PLAN
---------
1) Log in to the staff client
2) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/booksellers.pl
   -- It should say 'add to basket'.
3) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/basket.pl?basketno=1
   -- Assuming you have a basketno=1, it should say 'add to basket'.
4) Apply patch
5) Repeat steps 2 and 3.
   -- They should both have 'add order to basket' now.
6) Run koha qa test tools
   -- The problems mentioned on "221" are not related to this patch.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

NOTE: I generated the proper patch.
      And wrote the test plan more clearly.
      This patch does what it says it will do. However,
      I am not sure the rewording is best. Consider that the
      button on the basket page triggers a modal similar to the
      section at the bottom of the page. That is, is the button
      even necessary? Though, the rename of the button now will
      match the section header 'Add order to basket'. I leave
      the design decisions to someone else.
Comment 5 Katrin Fischer 2014-04-14 22:16:26 UTC
Looking at the various buttons in the acquisition module some of them seem quite verbose. This change would fit in, but I wonder, if we shouldn't rephrase in the other direction:

"Export this basket as CSV", could be "Export as CSV"
"Delete this basket", could be "Delete basket"
"Add order to basket" or "Add to basket" could be "New order line" or "Add order line".

I'd like to get another native speaker's opinion on this - Mark seemed a bit sceptical as well.
Comment 6 Paola Rossi 2014-12-02 14:45:05 UTC
There was no discussion about this topic after comment 5, so I pass this bug to "Resolved - Wontfix" status.