I think it would be a good idea to clarify better the function of the "add to basket" button on the vendor search results page /cgi-bin/koha/acqui/booksellers.pl and on the single basket page cgi-bin/koha/acqui/basket.pl?basketno=1. To make that, I suggest to add the word order. So "add to basket" could become ‘add order to basket’
Created attachment 26892 [details] Change text ‘Add to basket’ into ‘Add order to basket’ This patch changes the text ‘Add to basket’ into ‘Add order to basket’ in vendor search results page and the single basket page
Created attachment 26893 [details] patch for this bug
Created attachment 27070 [details] [review] Bug 12042 - Change text 'Add to basket' into 'Add order to basket' It would be a good idea to clarify better the function of the "add to basket" button on the vendor search results page and on the single basket page. To make that, I suggest to add the word 'order'. So, 'add to basket' would become 'add order to basket'. This is completely based on a cut-paste and git am of work done by Silvia Simonetti. TEST PLAN --------- 1) Log in to the staff client 2) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/booksellers.pl -- It should say 'add to basket'. 3) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/basket.pl?basketno=1 -- Assuming you have a basketno=1, it should say 'add to basket'. 4) Apply patch 5) Repeat steps 2 and 3. -- They should both have 'add order to basket' now. 6) Run koha qa test tools NOTE: I generated the proper patch.
Created attachment 27071 [details] [review] [SIGNED OFF] Bug 12042 - Change text 'Add to basket' into 'Add order to basket' It would be a good idea to clarify better the function of the "add to basket" button on the vendor search results page and on the single basket page. To make that, I suggest to add the word 'order'. So, 'add to basket' would become 'add order to basket'. This is completely based on a cut-paste and git am of work done by Silvia Simonetti. TEST PLAN --------- 1) Log in to the staff client 2) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/booksellers.pl -- It should say 'add to basket'. 3) Go to PROTOCOL://STAFFCLIENT/cgi-bin/koha/acqui/basket.pl?basketno=1 -- Assuming you have a basketno=1, it should say 'add to basket'. 4) Apply patch 5) Repeat steps 2 and 3. -- They should both have 'add order to basket' now. 6) Run koha qa test tools -- The problems mentioned on "221" are not related to this patch. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I generated the proper patch. And wrote the test plan more clearly. This patch does what it says it will do. However, I am not sure the rewording is best. Consider that the button on the basket page triggers a modal similar to the section at the bottom of the page. That is, is the button even necessary? Though, the rename of the button now will match the section header 'Add order to basket'. I leave the design decisions to someone else.
Looking at the various buttons in the acquisition module some of them seem quite verbose. This change would fit in, but I wonder, if we shouldn't rephrase in the other direction: "Export this basket as CSV", could be "Export as CSV" "Delete this basket", could be "Delete basket" "Add order to basket" or "Add to basket" could be "New order line" or "Add order line". I'd like to get another native speaker's opinion on this - Mark seemed a bit sceptical as well.
There was no discussion about this topic after comment 5, so I pass this bug to "Resolved - Wontfix" status.