Bugzilla – Attachment 28842 Details for
Bug 12422
Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12422 - Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap
Bug-12422---Javascript-error-triggered-by-opacbook.patch (text/plain), 1.69 KB, created by
Kyle M Hall
on 2014-06-13 14:58:22 UTC
(
hide
)
Description:
Bug 12422 - Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2014-06-13 14:58:22 UTC
Size:
1.69 KB
patch
obsolete
>From 1e66ba049d7b524a45ddc2f4d5b1be537621aaef Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 13 Jun 2014 10:48:29 -0400 >Subject: [PATCH] Bug 12422 - Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap > >Having the system preference opacbookbag disabled while having >virtualshelves enabled will give the following javascript error: > >Uncaught ReferenceError: MSG_IN_YOUR_CART is not defined basket.js:414 > >Test plan: >1) Set opactheme to bootstrap >2) Disable opacbookbag, enable virtualshelves >3) Open an OPAC page, view the error console >4) Note the javascript error >5) Apply this patch >6) Reload the page, not the error is gone >--- > .../bootstrap/en/includes/opac-bottom.inc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >index c3ce588..03b9d20 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >@@ -108,7 +108,7 @@ > //<![CDATA[ > var MSG_CONFIRM_AGAIN = _("Warning: Cannot be undone. Please confirm once again") > var MSG_DELETE_SEARCH_HISTORY = _("Are you sure you want to delete your search history?"); >- [% IF Koha.Preference( 'opacbookbag' ) == 1 %] >+ [% IF ( Koha.Preference( 'opacbookbag' ) == 1 ) || ( Koha.Preference( 'virtualshelves' ) == 1 ) %] > var MSG_BASKET_EMPTY = _("Your cart is currently empty"); > var MSG_RECORD_IN_BASKET = _("The item is already in your cart"); > var MSG_RECORD_ADDED = _("The item has been added to your cart"); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12422
: 28842