Bug 12422 - Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap
Summary: Javascript error triggered by opacbookbag being disabled while virtualshelves...
Status: RESOLVED DUPLICATE of bug 11663
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-13 14:48 UTC by Kyle M Hall
Modified: 2014-07-01 19:48 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12422 - Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap (1.69 KB, patch)
2014-06-13 14:58 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-06-13 14:48:15 UTC
Having the system preference opacbookbag disabled while having virtualshelves enabled will give the following javascript error:

Uncaught ReferenceError: MSG_IN_YOUR_CART is not defined basket.js:414
Comment 1 Kyle M Hall 2014-06-13 14:58:22 UTC
Created attachment 28842 [details] [review]
Bug 12422 - Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap

Having the system preference opacbookbag disabled while having
virtualshelves enabled will give the following javascript error:

Uncaught ReferenceError: MSG_IN_YOUR_CART is not defined basket.js:414

Test plan:
1) Set opactheme to bootstrap
2) Disable opacbookbag, enable virtualshelves
3) Open an OPAC page, view the error console
4) Note the javascript error
5) Apply this patch
6) Reload the page, not the error is gone
Comment 2 Owen Leonard 2014-06-18 13:14:56 UTC
Is this a duplicate of Bug 11663: fix display of holding tab in Bootstap OPAC when opacbookbag syspref is disabled?
Comment 3 Christopher Brannon 2014-06-19 22:07:08 UTC
(In reply to Owen Leonard from comment #2)
> Is this a duplicate of Bug 11663: fix display of holding tab in Bootstap
> OPAC when opacbookbag syspref is disabled?

I'm not seeing this behavior in master.  I'm thinking it may have been addressed in that bug.

Kyle, can you confirm if the problem still exists?

Christopher
Comment 4 Mayank 2014-06-24 07:16:36 UTC
I was facing the same problem.
Your patch solved it!
Thanks! :)


(In reply to Kyle M Hall from comment #1)
> Created attachment 28842 [details] [review] [review]
> Bug 12422 - Javascript error triggered by opacbookbag being disabled while
> virtualshelves are enabled when using Bootstrap
> 
> Having the system preference opacbookbag disabled while having
> virtualshelves enabled will give the following javascript error:
> 
> Uncaught ReferenceError: MSG_IN_YOUR_CART is not defined basket.js:414
> 
> Test plan:
> 1) Set opactheme to bootstrap
> 2) Disable opacbookbag, enable virtualshelves
> 3) Open an OPAC page, view the error console
> 4) Note the javascript error
> 5) Apply this patch
> 6) Reload the page, not the error is gone
Comment 5 Owen Leonard 2014-07-01 19:48:39 UTC

*** This bug has been marked as a duplicate of bug 11663 ***