Bugzilla – Attachment 44886 Details for
Bug 15175
IntranetBiblioDefaultView syspref is not respected when XSLTResultsDisplay is empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15175 Respect IntranetBiblioDefaultView syspref
PASSED-QA-Bug-15175-Respect-IntranetBiblioDefaultV.patch (text/plain), 4.26 KB, created by
Katrin Fischer
on 2015-11-16 19:27:27 UTC
(
hide
)
Description:
[PASSED QA] Bug 15175 Respect IntranetBiblioDefaultView syspref
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-11-16 19:27:27 UTC
Size:
4.26 KB
patch
obsolete
>From f2ad26a34a122a052318b009ddf85949acdb7302 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Wed, 11 Nov 2015 18:59:35 +0100 >Subject: [PATCH] [PASSED QA] Bug 15175 Respect IntranetBiblioDefaultView > syspref > >Respect IntranetBiblioDefaultView on intra search result page, on cover image >link, when XSLTResultsDisplay is empty. > >TO TEST: > >1. Empty XSLTResultsDisplay >2. Activate intranet local and Amazon cover images >3. Play changing IntranetBiblioDefault, and observe the links respectively on > biblio record title and cover image. Title's link is OK, cover image > link goes to detail.pl page independently of IntranetBiblioDefault. >4. Apply the patch. >5. Repeat 3. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Link to right display according with IntranetBiblioDefaultView is fixed. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >http://bugs.koha-community.org/show_bug.cgi?id=14175 >--- > .../intranet-tmpl/prog/en/modules/catalogue/results.tt | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 8f369ba..e011d1b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -3,6 +3,16 @@ > <title>Koha › Catalog › [% IF ( searchdesc ) %]Results of search [% IF ( query_desc ) %]for '[% query_desc | html %]'[% END %][% IF ( limit_desc ) %] with limit(s): '[% limit_desc | html %]'[% END %][% ELSE %]You did not specify any search criteria[% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] > [% INCLUDE 'browser-strings.inc' %] >+[% IF BiblioDefaultViewmarc %] >+ [% SET DetailPage="MARCdetail.pl" %] >+[% ELSIF BiblioDefaultViewlabeled_marc %] >+ [% SET DetailPage="labeledMARCdetail.pl" %] >+[% ELSIF BiblioDefaultViewisbd %] >+ [% SET DetailPage="ISBDdetail.pl" %] >+[% ELSE %] >+ [% SET DetailPage="detail.pl" %] >+[% END %] >+ > <!--[if lt IE 9]> > <script type="text/javascript" src="[% interface %]/lib/shims/json2.min.js"></script> > <![endif]--> >@@ -468,16 +478,16 @@ var holdForPatron = function () { > [% IF ( AmazonCoverImages || LocalCoverImages ) %] > <td> > [% IF ( LocalCoverImages) %] >- <a class="p1" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber |url %]"> >+ <a class="p1" href="/cgi-bin/koha/catalogue/[% DetailPage %]?biblionumber=[% SEARCH_RESULT.biblionumber |url %]"> > <span title="[% SEARCH_RESULT.biblionumber |url %]" class="[% SEARCH_RESULT.biblionumber %]" id="local-thumbnail[% loop.count %]"></span> > </a> > [% END %] > [% IF ( AmazonCoverImages ) %] > [% IF ( SEARCH_RESULT.normalized_isbn ) %] >- <a class="p1" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber |url %]"> >+ <a class="p1" href="/cgi-bin/koha/catalogue/[% DetailPage %]?biblionumber=[% SEARCH_RESULT.biblionumber |url %]"> > <img src="https://images-na.ssl-images-amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" /> > [% ELSIF ( !LocalCoverImages ) %] >- <a class="p1 no-amazon-cover" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber |url %]"> >+ <a class="p1 no-amazon-cover" href="/cgi-bin/koha/catalogue/[% DetailPage %]?biblionumber=[% SEARCH_RESULT.biblionumber |url %]"> > <img src="https://images-na.ssl-images-amazon.com/images/G/01/x-site/icons/no-img-sm.gif" alt="" class="thumbnail" /> > [% END %] > </a> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15175
:
44777
|
44809
| 44886