IntranetDefaultView syspref is not respected when XSLTResultsDisplay is empty: the link on cover images in search.pl result page goes always to detail.pl.
Created attachment 44777 [details] [review] Bug 15175 Respect IntranetBiblioDefaultView syspref Respect IntranetBiblioDefaultView on intra search result page, on cover image link, when XSLTResultsDisplay is empty. TO TEST: 1. Empty XSLTResultsDisplay 2. Activate intranet local and Amazon cover images 3. Play changing IntranetBiblioDefault, and observe the links respectively on biblio record title and cover image. Title's link is OK, cover image link goes to detail.pl page independently of IntranetBiblioDefault. 4. Apply the patch. 5. Repeat 3.
Created attachment 44809 [details] [review] [SIGNED-OFF]Bug 15175 Respect IntranetBiblioDefaultView syspref Respect IntranetBiblioDefaultView on intra search result page, on cover image link, when XSLTResultsDisplay is empty. TO TEST: 1. Empty XSLTResultsDisplay 2. Activate intranet local and Amazon cover images 3. Play changing IntranetBiblioDefault, and observe the links respectively on biblio record title and cover image. Title's link is OK, cover image link goes to detail.pl page independently of IntranetBiblioDefault. 4. Apply the patch. 5. Repeat 3. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Link to right display according with IntranetBiblioDefaultView is fixed.
We have formally deprecated the non-XSLT views a while ago: DEPR1: non-XSLT search results and bib display templates deprecated As of 2014-07-02, use of the XSLT search results and bib details display templates for the staff interface and public catalog is now the preferred option. Consequently, the non-XSLT option is now deprecated and it will not be maintained. Template files used by the non-XSLT bib and results displays need not be touched in future staff interface and public catalog enhancements; it is necessary only to update XSLT. --- As this is more of a bug fix, I have tested it. Leaving the final decision to our RM ;)
Created attachment 44886 [details] [review] [PASSED QA] Bug 15175 Respect IntranetBiblioDefaultView syspref Respect IntranetBiblioDefaultView on intra search result page, on cover image link, when XSLTResultsDisplay is empty. TO TEST: 1. Empty XSLTResultsDisplay 2. Activate intranet local and Amazon cover images 3. Play changing IntranetBiblioDefault, and observe the links respectively on biblio record title and cover image. Title's link is OK, cover image link goes to detail.pl page independently of IntranetBiblioDefault. 4. Apply the patch. 5. Repeat 3. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Link to right display according with IntranetBiblioDefaultView is fixed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> http://bugs.koha-community.org/show_bug.cgi?id=14175
Patch pushed to master. Thanks Frederic!
This patch has been pushed to 3.20.x, will be in 3.20.6.
Pushed to 3.18.13, and released.