Bugzilla – Attachment 45166 Details for
Bug 15228
Patron card batches - Improve translatability
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15228: Patron card batches - Improve translatability
Bug-15228-Patron-card-batches---Improve-translatab.patch (text/plain), 3.23 KB, created by
Jonathan Druart
on 2015-11-25 16:49:58 UTC
(
hide
)
Description:
Bug 15228: Patron card batches - Improve translatability
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-11-25 16:49:58 UTC
Size:
3.23 KB
patch
obsolete
>From 2de4b1cbcfe3a901b264b78921fa77b41a5ca36f Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sun, 22 Nov 2015 02:04:12 +0100 >Subject: [PATCH] Bug 15228: Patron card batches - Improve translatability > >This patch removes the \n\n from a translatable string >as those don't translate correctly to new lines. > >It also switches 'item' for 'patron' to avoid confusion >with catalog items. > >To test: >1) Trigger changed error message >- Create a new batch with 1 patron entry >- Select patron in list using the checkbox >- Click 'Remove selected patrons' in toolbar >- Verify alert displays correctly > >2) Verify that the page no longer uses "items" but > patrons instead. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >index ab5bbec..c45dabc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >@@ -32,7 +32,7 @@ > item_msg = item_num.join(", "); > var msg = _("Are you sure you want to remove card number(s): %s from this batch?").format(item_msg); > } else if (document.items.action.checked) { >- alert(_("Deletion of item from a batch with only one item will delete the batch.\n\nIf this is what you want, select 'Delete batch' option from toolbar")); >+ alert(_("Deletion of patron from a batch with only one patron will delete the batch.") + "\n\n" + _("If this is what you want, select the 'Delete batch' option from the toolbar")); > return; // no deletion for single item batch > } > else { >@@ -179,7 +179,7 @@ > > [% IF ( duplicate_message ) %] > <div class="dialog message"> >- <strong>[% duplicate_count %] duplicate item(s) found</strong> and removed from batch [% batch_id %]. >+ <strong>[% duplicate_count %] duplicate patron(s) found</strong> and removed from batch [% batch_id %]. > </div> > [% END %] > >@@ -256,8 +256,8 @@ > <fieldset class="rows" style="border-bottom: 0px; border: 0px;"> > <ol><li> > <div class="dialog message"> >- <h4>There are no items in this batch yet</h4> >- <p>Add items by borrowernumber using the text area above or leave empty to add via patron search.</p> >+ <h4>There are no patrons in this batch yet</h4> >+ <p>Add patrons by borrowernumber using the text area above or leave empty to add via patron search.</p> > </div> > </li></ol> > </fieldset> >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15228
:
45077
|
45090
|
45091
|
45116
|
45166
|
45167
|
46054
|
46055