Bug 15228 - Patron card batches - Improve translatability
Summary: Patron card batches - Improve translatability
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-21 01:15 UTC by Katrin Fischer
Modified: 2017-06-14 22:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15228: Patron card batches - Improve translatability (3.08 KB, patch)
2015-11-22 01:09 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15228: Patron card batches - Improve translatability (3.17 KB, patch)
2015-11-23 01:45 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15228: Switch "Items in batch number" (1.27 KB, patch)
2015-11-23 02:06 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15228: Switch "Items in batch number" (1.37 KB, patch)
2015-11-24 13:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15228: Patron card batches - Improve translatability (3.23 KB, patch)
2015-11-25 16:49 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15228: Switch "Items in batch number" (1.39 KB, patch)
2015-11-25 16:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15228: Patron card batches - Improve translatability (3.29 KB, patch)
2015-12-30 02:31 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Bug 15228: Switch "Items in batch number" (1.45 KB, patch)
2015-12-30 02:31 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2015-11-21 01:15:38 UTC
Found while translating:

"Deletion of item from a batch with only one item will delete the batch.\\n
\\n
If this is what you want, select 'Delete batch' option from toolbar"

\n should not be inside translated strings as the translation process breaks them.
Comment 1 Katrin Fischer 2015-11-22 01:09:54 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-11-23 01:45:48 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2015-11-23 02:06:17 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2015-11-24 13:37:32 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2015-11-25 16:49:58 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2015-11-25 16:50:02 UTC Comment hidden (obsolete)
Comment 7 Brendan Gallagher 2015-12-30 02:31:37 UTC
Created attachment 46054 [details] [review]
Bug 15228: Patron card batches - Improve translatability

This patch removes the \n\n from a translatable string
as those don't translate correctly to new lines.

It also switches 'item' for 'patron' to avoid confusion
with catalog items.

To test:
1) Trigger changed error message
- Create a new batch with 1 patron entry
- Select patron in list using the checkbox
- Click 'Remove selected patrons' in toolbar
- Verify alert displays correctly

2) Verify that the page no longer uses "items" but
   patrons instead.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 8 Brendan Gallagher 2015-12-30 02:31:45 UTC
Created attachment 46055 [details] [review]
Bug 15228: Switch "Items in batch number"

Yet another line to switch "Items in batch number" to
"Patrons in batch number"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 9 Brendan Gallagher 2015-12-30 02:32:15 UTC
Pushed to Master - Thanks
Comment 10 Julian Maurice 2015-12-31 08:26:29 UTC
Patches pushed to 3.22.x, will be in 3.22.2
Comment 11 Frédéric Demians 2015-12-31 18:27:39 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.