Found while translating: "Deletion of item from a batch with only one item will delete the batch.\\n \\n If this is what you want, select 'Delete batch' option from toolbar" \n should not be inside translated strings as the translation process breaks them.
Created attachment 45077 [details] [review] Bug 15228: Patron card batches - Improve translatability This patch removes the \n\n from a translatable string as those don't translate correctly to new lines. It also switches 'item' for 'patron' to avoid confusion with catalog items. To test: 1) Trigger changed error message - Create a new batch with 1 patron entry - Select patron in list using the checkbox - Click 'Remove selected patrons' in toolbar - Verify alert displays correctly 2) Verify that the page no longer uses "items" but patrons instead.
Created attachment 45090 [details] [review] [SIGNED-OFF]Bug 15228: Patron card batches - Improve translatability This patch removes the \n\n from a translatable string as those don't translate correctly to new lines. It also switches 'item' for 'patron' to avoid confusion with catalog items. To test: 1) Trigger changed error message - Create a new batch with 1 patron entry - Select patron in list using the checkbox - Click 'Remove selected patrons' in toolbar - Verify alert displays correctly 2) Verify that the page no longer uses "items" but patrons instead. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
Created attachment 45091 [details] [review] Bug 15228: Switch "Items in batch number" Yet another line to switch "Items in batch number" to "Patrons in batch number"
Created attachment 45116 [details] [review] [SIGNED-OFF] Bug 15228: Switch "Items in batch number" Yet another line to switch "Items in batch number" to "Patrons in batch number" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 45166 [details] [review] Bug 15228: Patron card batches - Improve translatability This patch removes the \n\n from a translatable string as those don't translate correctly to new lines. It also switches 'item' for 'patron' to avoid confusion with catalog items. To test: 1) Trigger changed error message - Create a new batch with 1 patron entry - Select patron in list using the checkbox - Click 'Remove selected patrons' in toolbar - Verify alert displays correctly 2) Verify that the page no longer uses "items" but patrons instead. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 45167 [details] [review] Bug 15228: Switch "Items in batch number" Yet another line to switch "Items in batch number" to "Patrons in batch number" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 46054 [details] [review] Bug 15228: Patron card batches - Improve translatability This patch removes the \n\n from a translatable string as those don't translate correctly to new lines. It also switches 'item' for 'patron' to avoid confusion with catalog items. To test: 1) Trigger changed error message - Create a new batch with 1 patron entry - Select patron in list using the checkbox - Click 'Remove selected patrons' in toolbar - Verify alert displays correctly 2) Verify that the page no longer uses "items" but patrons instead. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Created attachment 46055 [details] [review] Bug 15228: Switch "Items in batch number" Yet another line to switch "Items in batch number" to "Patrons in batch number" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Pushed to Master - Thanks
Patches pushed to 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.