Bugzilla – Attachment 6564 Details for
Bug 2346
consolidate duplicate methods C4::Overdues::UpdateBorrowerDebarred and C4::Members::DebarMember
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch to remove UpdateBorrowerDebarred
0001-Bug-2346-Remove-C4-Overdues-UpdateBorrowerDebarred-i.patch (text/plain), 2.09 KB, created by
Ian Walls
on 2011-12-04 17:21:25 UTC
(
hide
)
Description:
Proposed patch to remove UpdateBorrowerDebarred
Filename:
MIME Type:
Creator:
Ian Walls
Created:
2011-12-04 17:21:25 UTC
Size:
2.09 KB
patch
obsolete
>From fae76a8ecb22c1559bd30f4577a2277b7d49cef8 Mon Sep 17 00:00:00 2001 >From: Ian Walls <ian.walls@bywatersolutions.com> >Date: Sun, 4 Dec 2011 12:19:29 -0500 >Subject: [PATCH] Bug 2346: Remove C4::Overdues::UpdateBorrowerDebarred in favour of C4::Members::DebarMember > >Removes now-unused subroutine from C4::Overdues, as well as the db_dependent unit test >--- > C4/Overdues.pm | 23 ----------------------- > t/db_dependent/lib/KohaTest/Overdues.pm | 1 - > 2 files changed, 0 insertions(+), 24 deletions(-) > >diff --git a/C4/Overdues.pm b/C4/Overdues.pm >index 7e9b9c9..4897b41 100644 >--- a/C4/Overdues.pm >+++ b/C4/Overdues.pm >@@ -79,7 +79,6 @@ BEGIN { > # subs to move to Members.pm > push @EXPORT, qw( > &CheckBorrowerDebarred >- &UpdateBorrowerDebarred > ); > # subs to move to Biblio.pm > push @EXPORT, qw( >@@ -1085,28 +1084,6 @@ sub CheckBorrowerDebarred { > return $debarredstatus; > } > >-=head2 UpdateBorrowerDebarred >- >-($borrowerstatut) = &UpdateBorrowerDebarred($borrowernumber, $todate); >- >-update status of borrowers in borrowers table (field debarred) >- >-C<$borrowernumber> borrower number >- >-=cut >- >-sub UpdateBorrowerDebarred{ >- my ( $borrowernumber, $todate ) = @_; >- my $dbh = C4::Context->dbh; >- my $query = qq|UPDATE borrowers >- SET debarred=? >- WHERE borrowernumber=? >- |; >- my $sth = $dbh->prepare($query); >- $sth->execute( $todate, $borrowernumber ); >- $sth->finish; >- return 1; >-} > > =head2 CheckExistantNotifyid > >diff --git a/t/db_dependent/lib/KohaTest/Overdues.pm b/t/db_dependent/lib/KohaTest/Overdues.pm >index 949c670..13eb1f2 100644 >--- a/t/db_dependent/lib/KohaTest/Overdues.pm >+++ b/t/db_dependent/lib/KohaTest/Overdues.pm >@@ -34,7 +34,6 @@ sub methods : Test( 1 ) { > CheckAccountLineLevelInfo > GetOverduerules > CheckBorrowerDebarred >- UpdateBorrowerDebarred > CheckExistantNotifyid > CheckAccountLineItemInfo > CheckItemNotify >-- >1.7.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2346
:
6564
|
6584