---- Reported by Andrew.moore@liblime.com 2008-07-11 10:17:43 ---- The two methods C4::Overdues::UpdateBorrowerDebarred and C4::Members::DebarMember appear to do the exact same thing. We only need one sub for this. I think this sub belongs in the C4::Members namespace. Therefore, I'll replace the guts of UpdaetBorrowerDebarred with a call to DebarMember and document that sub as deprecated. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:50 UTC --- This bug was previously known as _bug_ 2346 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2346 Actual time not defined. Setting to 0.0 The original reporter of this bug does not have an account here. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. Previous reporter was Andrew.moore@liblime.com.
Is this bug still valid? I think there were some development for debarment of patrons since this bug was filed.
This issue is resolved with the inclusion of bug 6328. UpdateBorrowerDebarred has been removed from usage except in the deprecated script notifyMailsOp.pl, and there it is overridden by a local subroutine. This script has a bug filed against it for removal (bug 7315), so I believe it is safe to remove UpdateBorrowerDebarred from C4::Overdues. Patch forthcoming.
Created attachment 6564 [details] [review] Proposed patch to remove UpdateBorrowerDebarred Removes UpdateBorrowerDebarred subroutine and associated test, now that it's no longer relevant (since bug 6328)
Created attachment 6584 [details] [review] Bug 2346: Remove C4::Overdues::UpdateBorrowerDebarred in favour of C4::Members::DebarMember Removes now-unused subroutine from C4::Overdues, as well as the db_dependent unit test Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
QA comment: nothing to say, remove dead code. Digging into this patch to check all UpdateBorrowerDebarred calls were removed showed me that the notifyMailsOp.pl was still here. Added a follow-up to remove this script Patch pushed, please test
This patch does not apply cleanly to 3.6.x branch. Please rebase over that branch and attach a corrected patch to this bug report.
There have been no further reports of problems so I am marking this bug resolved.