Bugzilla – Attachment 75701 Details for
Bug 20838
Search by group of libraries is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20838: Make Koha::Library::Group->all_libraries return a list of Koha::Libraries
Bug-20838-Make-KohaLibraryGroup-alllibraries-retur.patch (text/plain), 1.14 KB, created by
Kyle M Hall (khall)
on 2018-05-31 12:15:49 UTC
(
hide
)
Description:
Bug 20838: Make Koha::Library::Group->all_libraries return a list of Koha::Libraries
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2018-05-31 12:15:49 UTC
Size:
1.14 KB
patch
obsolete
>From 3f056c0404ef08fbfc5ad278ccd8817e7650e2cf Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 30 May 2018 14:53:28 -0300 >Subject: [PATCH] Bug 20838: Make Koha::Library::Group->all_libraries return a > list of Koha::Libraries > >Instead of a list of Koha::Library::Group >Ideally it should be a Koh::Libraries iterator > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/Library/Group.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/Koha/Library/Group.pm b/Koha/Library/Group.pm >index a54e5b1a60..cf40330545 100644 >--- a/Koha/Library/Group.pm >+++ b/Koha/Library/Group.pm >@@ -148,7 +148,7 @@ sub all_libraries { > my @children = $self->children; > foreach my $c (@children) { > if ( $c->branchcode ) { >- push( @libraries, $c ); >+ push( @libraries, $c->library ); > } > else { > push( @libraries, $c->all_libraries ); >@@ -159,7 +159,6 @@ sub all_libraries { > @libraries = > grep { !$seen{ $_->id }++ } @libraries; > >-# return wantarray ? @li : $children; > return @libraries; > } > >-- >2.15.1 (Apple Git-101)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20838
:
75686
|
75687
|
75700
|
75701
|
75731
|
75732
|
75739