In the last patches of bug 16735, we completely broke the feature! The limit is using library_groups.id instead of branches.branchcode.
Created attachment 75686 [details] [review] Bug 20838: (bug 16735 follow-up) Fix search by group of libraries In the last patches of bug 16735, we completely broke the feature! The limit is using library_groups.id instead of branches.branchcode. Test plan: Create a group of library with the search feature Search (OPAC and staff interfaces) using this limit => Without this patch you will see that the generated search query does not contain branchcodes => With this patch applied you will see the branchcodes
Created attachment 75687 [details] [review] Bug 20838: Make Koha::Library::Group->all_libraries return a list of Koha::Libraries Instead of a list of Koha::Library::Group Ideally it should be a Koh::Libraries iterator
Created attachment 75700 [details] [review] Bug 20838: (bug 16735 follow-up) Fix search by group of libraries In the last patches of bug 16735, we completely broke the feature! The limit is using library_groups.id instead of branches.branchcode. Test plan: Create a group of library with the search feature Search (OPAC and staff interfaces) using this limit => Without this patch you will see that the generated search query does not contain branchcodes => With this patch applied you will see the branchcodes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 75701 [details] [review] Bug 20838: Make Koha::Library::Group->all_libraries return a list of Koha::Libraries Instead of a list of Koha::Library::Group Ideally it should be a Koh::Libraries iterator Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA: Looking here
Created attachment 75731 [details] [review] Bug 20838: (bug 16735 follow-up) Fix search by group of libraries In the last patches of bug 16735, we completely broke the feature! The limit is using library_groups.id instead of branches.branchcode. Test plan: Create a group of library with the search feature Search (OPAC and staff interfaces) using this limit => Without this patch you will see that the generated search query does not contain branchcodes => With this patch applied you will see the branchcodes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 75732 [details] [review] Bug 20838: Make Koha::Library::Group->all_libraries return a list of Koha::Libraries Instead of a list of Koha::Library::Group Ideally it should be a Koh::Libraries iterator Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Test coverage of all_libraries is rather limited..
Created attachment 75739 [details] [review] Bug 20838: Add 2 small tests to check ref
I am having issues testing this - when I enable "OpacAddMastheadLibraryPulldown" I don't have a list of libraries and my group doesn't show any values
(In reply to Nick Clemens from comment #10) > I am having issues testing this - when I enable > "OpacAddMastheadLibraryPulldown" I don't have a list of libraries and my > group doesn't show any values Right, it's another bug. I am going to deal with it on a separate bug report. To test this one you need to use the advanced search form.
Pushed to master for 18.11, awesome work everybody!
This patch has been pushed to 18.05.x and will be in 18.05.01
Depends on Bug 16735 not in 17.11.x