Attachment 75732 Details for Bug 20838 – Bug 20838: Make Koha::Library::Group->all_libraries return a list of Koha::Libraries

[patch] Bug 20838: Make Koha::Library::Group->all_libraries return a list of Koha::Libraries

Bug-20838-Make-KohaLibraryGroup-alllibraries-retur.patch (text/plain), 1.21 KB, created by Marcel de Rooy on 2018-06-01 09:43:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2018-06-01 09:43:48 UTC

Size: 1.21 KB

patch

obsolete

>From 62281bc782d303c589974db19cdf3b81e5367616 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 30 May 2018 14:53:28 -0300
>Subject: [PATCH] Bug 20838: Make Koha::Library::Group->all_libraries return a
> list of Koha::Libraries
>Content-Type: text/plain; charset=utf-8
>
>Instead of a list of Koha::Library::Group
>Ideally it should be a Koh::Libraries iterator
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Library/Group.pm | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/Koha/Library/Group.pm b/Koha/Library/Group.pm
>index a54e5b1..cf40330 100644
>--- a/Koha/Library/Group.pm
>+++ b/Koha/Library/Group.pm
>@@ -148,7 +148,7 @@ sub all_libraries {
>     my @children = $self->children;
>     foreach my $c (@children) {
>         if ( $c->branchcode ) {
>-            push( @libraries, $c );
>+            push( @libraries, $c->library );
>         }
>         else {
>             push( @libraries, $c->all_libraries );
>@@ -159,7 +159,6 @@ sub all_libraries {
>     @libraries =
>       grep { !$seen{ $_->id }++ } @libraries;
> 
>-#    return wantarray ? @li : $children;
>     return @libraries;
> }
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20838: 75686 | 75687 | 75700 | 75701 | 75731 | 75732 | 75739