Bugzilla – Attachment 89594 Details for
Bug 22878
Cannot add a patron card layout with mysql strict mode on
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22878: Add tests
Bug-22878-Add-tests.patch (text/plain), 2.29 KB, created by
Katrin Fischer
on 2019-05-11 10:22:23 UTC
(
hide
)
Description:
Bug 22878: Add tests
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-05-11 10:22:23 UTC
Size:
2.29 KB
patch
obsolete
>From b885ec8d5cca8582b4d8992afc9d48539840be01 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 10 May 2019 12:27:34 -0500 >Subject: [PATCH] Bug 22878: Add tests > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > t/Patroncards_Layout.t | 14 -------------- > t/db_dependent/Patroncards.t | 34 ++++++++++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+), 14 deletions(-) > delete mode 100755 t/Patroncards_Layout.t > create mode 100755 t/db_dependent/Patroncards.t > >diff --git a/t/Patroncards_Layout.t b/t/Patroncards_Layout.t >deleted file mode 100755 >index fe687612b8..0000000000 >--- a/t/Patroncards_Layout.t >+++ /dev/null >@@ -1,14 +0,0 @@ >-#!/usr/bin/perl >-# >-# This Koha test module is a stub! >-# Add more tests here!!! >- >-use strict; >-use warnings; >- >-use Test::More tests => 1; >- >-BEGIN { >- use_ok('C4::Patroncards::Layout'); >-} >- >diff --git a/t/db_dependent/Patroncards.t b/t/db_dependent/Patroncards.t >new file mode 100755 >index 0000000000..3f9b742e31 >--- /dev/null >+++ b/t/db_dependent/Patroncards.t >@@ -0,0 +1,34 @@ >+#!/usr/bin/perl >+ >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+use Test::More tests => 1; >+use Test::MockModule; >+use t::lib::Mocks; >+use t::lib::TestBuilder; >+ >+use C4::Patroncards::Layout; >+ >+subtest '->save' => sub { >+ plan tests => 1; >+ my $layout = C4::Patroncards::Layout->new( >+ layout_name => "new patron card", >+ layout_id => '', # The interface send an empty string >+ layout_xml => 'some_xml' >+ ); >+ my $layout_id = $layout->save; >+ ok($layout_id > 0, 'A layout_id should have been returned on ->save'); >+}; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22878
:
89562
|
89563
|
89575
|
89576
| 89594 |
89595