Attempting to create a patron card layout with mysql strict mode on gives the following error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 [for Statement "INSERT INTO creator_layouts (creator, layout_id, units, layout_xml, layout_name) VALUES (?,?,?,?,?);" with ParamValues: 0='Patroncards', 1="", 2="POINT", 3="<opt guide_box="0" guide_grid="0" page_side="F" units="POINT"> </opt> ", 4="something"] at /kohadevbox/koha/C4/Creators/Layout.pm line 181. Database returned the following error: Incorrect integer value: '' for column 'layout_id' at row 1 at /kohadevbox/koha/C4/Creators/Layout.pm line 183.
Created attachment 89562 [details] [review] Bug 22878: Add tests
Created attachment 89563 [details] [review] Bug 22878: Do not pass layout_id on creating a layout Attempting to create a patron card layout with mysql strict mode on gives the following error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 Test plan: - Turn on sql_strict_modes - Create a new patron card => Must success with this patch applied
Created attachment 89575 [details] [review] Bug 22878: Add tests Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 89576 [details] [review] Bug 22878: Do not pass layout_id on creating a layout Attempting to create a patron card layout with mysql strict mode on gives the following error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 Test plan: - Turn on sql_strict_modes - Create a new patron card => Must success with this patch applied Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 89594 [details] [review] Bug 22878: Add tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 89595 [details] [review] Bug 22878: Do not pass layout_id on creating a layout Attempting to create a patron card layout with mysql strict mode on gives the following error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 Test plan: - Turn on sql_strict_modes - Create a new patron card => Must success with this patch applied Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.06
Pushed to 18.05 for 18.05.14