Bugzilla – Attachment 89595 Details for
Bug 22878
Cannot add a patron card layout with mysql strict mode on
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22878: Do not pass layout_id on creating a layout
Bug-22878-Do-not-pass-layoutid-on-creating-a-layou.patch (text/plain), 1.17 KB, created by
Katrin Fischer
on 2019-05-11 10:22:27 UTC
(
hide
)
Description:
Bug 22878: Do not pass layout_id on creating a layout
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-05-11 10:22:27 UTC
Size:
1.17 KB
patch
obsolete
>From ae6d6cdafe756c40f8c241cc36edeb463fc9d9a3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 10 May 2019 12:27:40 -0500 >Subject: [PATCH] Bug 22878: Do not pass layout_id on creating a layout > >Attempting to create a patron card layout with mysql strict mode on gives the following error: > DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 > >Test plan: >- Turn on sql_strict_modes >- Create a new patron card >=> Must success with this patch applied > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Creators/Layout.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Creators/Layout.pm b/C4/Creators/Layout.pm >index f1dc20edd4..2a689e0352 100644 >--- a/C4/Creators/Layout.pm >+++ b/C4/Creators/Layout.pm >@@ -165,6 +165,7 @@ sub save { > } > else { # otherwise create a new record > my @params; >+ delete $self->{layout_id}; # Could be an empty string > my $query = "INSERT INTO creator_layouts ("; > foreach my $key (keys %{$self}) { > push (@params, $self->{$key}); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22878
:
89562
|
89563
|
89575
|
89576
|
89594
| 89595