Bugzilla – Attachment 120762 Details for
Bug 28229
Hide clubs from place a hold screen if no clubs exist
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28229: Count only if needed
Bug-28229-Count-only-if-needed.patch (text/plain), 1.22 KB, created by
Jonathan Druart
on 2021-05-10 10:09:05 UTC
(
hide
)
Description:
Bug 28229: Count only if needed
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-05-10 10:09:05 UTC
Size:
1.22 KB
patch
obsolete
>From 055573512c1f4f5187c73e5d9027c5d628dd05db Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 10 May 2021 12:08:21 +0200 >Subject: [PATCH] Bug 28229: Count only if needed > >We don't need to count the number of clubs if we selected a patron or >club already >--- > reserve/request.pl | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 98ffd64d24e..9c83b617cfb 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -168,11 +168,9 @@ if ( $biblionumbers ) { > push @biblionumbers, $input->multi_param('biblionumber'); > } > >-my $clubcount = Koha::Clubs->search->count; > my $multi_hold = @biblionumbers > 1; > $template->param( >- multi_hold => $multi_hold, >- clubcount => $clubcount, >+ multi_hold => $multi_hold, > ); > > # If we have the borrowernumber because we've performed an action, then we >@@ -276,6 +274,10 @@ if ($club_hold && !$borrowernumber_hold && !$action) { > ); > } > >+unless ( $club_hold or $borrowernumber_hold ) { >+ $template->param( clubcount => Koha::Clubs->search->count ); >+} >+ > $template->param( > messageborrower => $messageborrower, > messageclub => $messageclub >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28229
:
120573
|
120681
|
120682
|
120715
|
120729
|
120730
| 120762