When placing a hold, one always sees the option to search for a club rather than a patron. We should hide that Clubs tab if no clubs exist in the system.
Created attachment 120573 [details] [review] Bug 28229: Only show clubs on request.tt if clubs exist 1. Have no existing clubs 2. Apply patch 3. Go to request.tt and you will not see the club tab or any mention of clubs 4. Create at least 1 club 5. Go back to request.tt and now see the tab for clubs 6. Make sure you can place holds as an individual with and without clubs. 7. Make sure you can place holds for clubs. 8. rejoice and sign-off
Created attachment 120681 [details] [review] Bug 28229: Only show clubs on request.tt if clubs exist 1. Have no existing clubs 2. Apply patch 3. Go to request.tt and you will not see the club tab or any mention of clubs 4. Create at least 1 club 5. Go back to request.tt and now see the tab for clubs 6. Make sure you can place holds as an individual with and without clubs. 7. Make sure you can place holds for clubs. 8. rejoice and sign-off Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 120682 [details] [review] Bug 28229: (follow-up) Adjust for easier translation I think moving the [% IF %] out of the HTML tag makes for easier translation.
Created attachment 120715 [details] [review] Bug 28229: (follow-up) Adjust for easier translation I think moving the [% IF %] out of the HTML tag makes for easier translation. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 120729 [details] [review] Bug 28229: Only show clubs on request.tt if clubs exist 1. Have no existing clubs 2. Apply patch 3. Go to request.tt and you will not see the club tab or any mention of clubs 4. Create at least 1 club 5. Go back to request.tt and now see the tab for clubs 6. Make sure you can place holds as an individual with and without clubs. 7. Make sure you can place holds for clubs. 8. rejoice and sign-off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 120730 [details] [review] Bug 28229: (follow-up) Adjust for easier translation I think moving the [% IF %] out of the HTML tag makes for easier translation. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Really nice enh for libraries not using the club feature - cutting down on confusion.
Created attachment 120762 [details] [review] Bug 28229: Count only if needed We don't need to count the number of clubs if we selected a patron or club already
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.06
Pushed to 20.05.x for 20.05.12
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.