Bugzilla – Attachment 143526 Details for
Bug 32141
New and edit identity provider UIs inconsistent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32141: Add missing fieldset legends and titlecase "matchpoint"
Bug-32141-Add-missing-fieldset-legends-and-titleca.patch (text/plain), 2.56 KB, created by
Tomás Cohen Arazi
on 2022-11-09 16:39:18 UTC
(
hide
)
Description:
Bug 32141: Add missing fieldset legends and titlecase "matchpoint"
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2022-11-09 16:39:18 UTC
Size:
2.56 KB
patch
obsolete
>From c53a114857fe90b173d3393f808bbec4198b6baf Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Wed, 9 Nov 2022 02:10:55 +0000 >Subject: [PATCH] Bug 32141: Add missing fieldset legends and titlecase > "matchpoint" > >This patch adds missing fieldset legends and titlecases "matchpoint", >so that the "Edit" UI is consistent with the "New" UI for adding >and modifying Identity Providers. > >Test plan: >1) Apply patches >2) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form >3) Fill out the fields to add an identity provider >4) Click "Edit" next to the Identity Provider in the list >5) In a new tab, go to >http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form >6) Compare the two screens and note that all the labels, inputs, and help text >are the same on both screens. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../intranet-tmpl/prog/en/modules/admin/identity_providers.tt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt >index 7b69bb30804..3c56c09270f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt >@@ -244,6 +244,7 @@ > <input type="hidden" name="op" value="edit_save" /> > <input type="hidden" name="identity_provider_id" value="[%- identity_provider.identity_provider_id | html -%]" /> > <fieldset class="rows"> >+ <legend id="identity_provider_basic">Basic configuration</legend> > <ol> > <li> > <label for="code" class="required">Code: </label> >@@ -282,6 +283,7 @@ > </fieldset> > > <fieldset class="rows"> >+ <legend id="identity_provider_advanced">Advanced configuration</legend> > <ol> > <li> > <label for="config" class="required json">Configuration: </label> >@@ -313,7 +315,7 @@ > </div> > </li> > <li> >- <label for="matchpoint">matchpoint: </label> >+ <label for="matchpoint">Matchpoint: </label> > <select name="matchpoint" id="matchpoint"> > [%- IF identity_provider.matchpoint == 'email' -%] > <option value="email" selected="selected">Email</option> >-- >2.38.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32141
:
143455
|
143456
|
143525
| 143526