Bug 32141 - New and edit identity provider UIs inconsistent
Summary: New and edit identity provider UIs inconsistent
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on: 31378
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-09 00:37 UTC by David Cook
Modified: 2023-06-08 22:29 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32141: Fix textbox formatting on edit IdP screen (2.33 KB, patch)
2022-11-09 02:13 UTC, David Cook
Details | Diff | Splinter Review
Bug 32141: Add missing fieldset legends and titlecase "matchpoint" (2.50 KB, patch)
2022-11-09 02:13 UTC, David Cook
Details | Diff | Splinter Review
Bug 32141: Fix textbox formatting on edit IdP screen (2.38 KB, patch)
2022-11-09 16:39 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 32141: Add missing fieldset legends and titlecase "matchpoint" (2.56 KB, patch)
2022-11-09 16:39 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2022-11-09 00:37:55 UTC
When adding an Identity Provider, the textboxes are 75 columns by 10 rows.

But when editing an Identity Provider, the boxes don't have explicit sizing, and they're too small and always need to be manually resized. 

Not a big drama but it's annoying.
Comment 1 David Cook 2022-11-09 02:13:55 UTC
Created attachment 143455 [details] [review]
Bug 32141: Fix textbox formatting on edit IdP screen

This patch makes the textbox have the same number of rows and columns
on the "Edit" page as it does on the "New" page for Identity Providers.
Comment 2 David Cook 2022-11-09 02:13:59 UTC
Created attachment 143456 [details] [review]
Bug 32141: Add missing fieldset legends and titlecase "matchpoint"

This patch adds missing fieldset legends and titlecases "matchpoint",
so that the "Edit" UI is consistent with the "New" UI for adding
and modifying Identity Providers.

Test plan:
1) Apply patches
2) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
3) Fill out the fields to add an identity provider
4) Click "Edit" next to the Identity Provider in the list
5) In a new tab, go to
http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
6) Compare the two screens and note that all the labels, inputs, and help text
are the same on both screens.
Comment 3 Tomás Cohen Arazi 2022-11-09 11:28:42 UTC
(In reply to David Cook from comment #0)
> When adding an Identity Provider, the textboxes are 75 columns by 10 rows.
> 
> But when editing an Identity Provider, the boxes don't have explicit sizing,
> and they're too small and always need to be manually resized. 
> 
> Not a big drama but it's annoying.

Yeah, I added that on my last follow-up on the bug, and forgot to tweak the edit page. Thanks!
Comment 4 Tomás Cohen Arazi 2022-11-09 16:39:13 UTC
Created attachment 143525 [details] [review]
Bug 32141: Fix textbox formatting on edit IdP screen

This patch makes the textbox have the same number of rows and columns
on the "Edit" page as it does on the "New" page for Identity Providers.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi 2022-11-09 16:39:18 UTC
Created attachment 143526 [details] [review]
Bug 32141: Add missing fieldset legends and titlecase "matchpoint"

This patch adds missing fieldset legends and titlecases "matchpoint",
so that the "Edit" UI is consistent with the "New" UI for adding
and modifying Identity Providers.

Test plan:
1) Apply patches
2) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
3) Fill out the fields to add an identity provider
4) Click "Edit" next to the Identity Provider in the list
5) In a new tab, go to
http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
6) Compare the two screens and note that all the labels, inputs, and help text
are the same on both screens.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi 2022-11-09 17:40:34 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!