Bugzilla – Attachment 143633 Details for
Bug 31752
Alignment of labels in notices is wonky
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31752: Move hidden input fields
Bug-31752-Move-hidden-input-fields.patch (text/plain), 2.60 KB, created by
Katrin Fischer
on 2022-11-10 10:15:46 UTC
(
hide
)
Description:
Bug 31752: Move hidden input fields
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-11-10 10:15:46 UTC
Size:
2.60 KB
patch
obsolete
>From f800ddd53f2a5e260d8afbc87158b93735144b46 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 8 Nov 2022 14:48:21 +0000 >Subject: [PATCH] Bug 31752: Move hidden input fields > >There didn't appear to be any reason to have the hidden form fields here >nested in the ordered list and they were causing undesired styling >issues. > >This patch simply moves them to the beggining of the fieldset. > >Test plan >1) Confirm the 'HTML message' label now aligns correctly > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >index f3f0f70c59..7fd3e6b674 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >@@ -500,6 +500,8 @@ > [% ELSE %] > <fieldset class="rows mtt"> > [% END %] >+ <input type="hidden" name="message_transport_type" value="[% letter.message_transport_type | html %]" /> >+ <input type="hidden" name="lang" value="[% lang | html %]" /> > <ol> > [% IF ( letter.tt_error ) %] > <li class="template_toolkit_error"> >@@ -514,8 +516,6 @@ > </li> > [% END %] > <li> >- <input type="hidden" name="message_transport_type" value="[% letter.message_transport_type | html %]" /> >- <input type="hidden" name="lang" value="[% lang | html %]" /> > <label for="is_html_[% letter.message_transport_type | html %]_[% lang | html %]">HTML message:</label> > [% IF letter.is_html %] > <input type="checkbox" name="is_html_[% letter.message_transport_type | html %]_[% lang | html %]" id="is_html_[% letter.message_transport_type | html %]_[% lang | html %]" value="1" checked="checked" /> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31752
:
141756
|
143395
|
143419
| 143633