Bug 31752 - Alignment of labels in notices is wonky
Summary: Alignment of labels in notices is wonky
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Martin Renvoize
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-12 22:44 UTC by Lucas Gass
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Screenshot of problem (13.14 KB, image/png)
2022-10-12 22:44 UTC, Lucas Gass
Details
Bug 31852: Move hidden input fields (2.60 KB, patch)
2022-11-08 14:50 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31752: Move hidden input fields (2.55 KB, patch)
2022-11-08 15:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31752: Move hidden input fields (2.60 KB, patch)
2022-11-10 10:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-10-12 22:44:39 UTC
Created attachment 141756 [details]
Screenshot of problem

The alignment of the labels in the notices tool is off. ( see attachment )
Comment 1 Martin Renvoize 2022-11-08 14:50:31 UTC
Created attachment 143395 [details] [review]
Bug 31852: Move hidden input fields

There didn't appear to be any reason to have the hidden form fields here
nested in the ordered list and they were causing undesired styling
issues.

This patch simply moves them to the beggining of the fieldset.

Test plan
1) Confirm the 'HTML message' label now aligns correctly
Comment 2 Martin Renvoize 2022-11-08 14:51:15 UTC
Straight to QA, trivial patch, just needs regression testing by a QA member please.
Comment 3 Martin Renvoize 2022-11-08 15:01:13 UTC
Created attachment 143419 [details] [review]
Bug 31752: Move hidden input fields

There didn't appear to be any reason to have the hidden form fields here
nested in the ordered list and they were causing undesired styling
issues.

This patch simply moves them to the beggining of the fieldset.

Test plan
1) Confirm the 'HTML message' label now aligns correctly
Comment 4 Katrin Fischer 2022-11-10 10:15:46 UTC
Created attachment 143633 [details] [review]
Bug 31752: Move hidden input fields

There didn't appear to be any reason to have the hidden form fields here
nested in the ordered list and they were causing undesired styling
issues.

This patch simply moves them to the beggining of the fieldset.

Test plan
1) Confirm the 'HTML message' label now aligns correctly

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-11-10 13:05:48 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!