Bugzilla – Attachment 145141 Details for
Bug 32349
Remove TEST_QA
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32349: Remove TEST_QA
Bug-32349-Remove-TESTQA.patch (text/plain), 1.31 KB, created by
Marcel de Rooy
on 2023-01-09 12:07:52 UTC
(
hide
)
Description:
Bug 32349: Remove TEST_QA
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-01-09 12:07:52 UTC
Size:
1.31 KB
patch
obsolete
>From 1c625d0bbb5f9723515f8d4e36df2fd012087394 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 25 Nov 2022 09:07:34 +0100 >Subject: [PATCH] Bug 32349: Remove TEST_QA >Content-Type: text/plain; charset=utf-8 > >There is an env var that we are passing from koha-testing-docker, TEST_QA. >It's used in Koha from a single test file, t/00-testcritic.t. >If not set, no test is run. > >Do we really need this? libtest-perl-critic-perl is packaged and automatically installed. > >Signed-off-by: Mason James <mtj@kohaaloha.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/00-testcritic.t | 7 ------- > 1 file changed, 7 deletions(-) > >diff --git a/t/00-testcritic.t b/t/00-testcritic.t >index 4c7f44132a..cd3a7af71b 100755 >--- a/t/00-testcritic.t >+++ b/t/00-testcritic.t >@@ -1,18 +1,11 @@ > #!/usr/bin/env perl > > # This script can be used to run perlcritic on perl files in koha >-# The script is purely optional requiring Test::Perl::Critic to be installed >-# and the environment variable TEST_QA to be set > > use Modern::Perl; > use Test::More; > use English qw(-no_match_vars); > >-if ( not $ENV{TEST_QA} ) { >- my $msg = 'Author test. Set $ENV{TEST_QA} to a true value to run'; >- plan( skip_all => $msg ); >-} >- > eval { require Test::Perl::Critic; }; > > if ( $EVAL_ERROR ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32349
:
144226
|
144374
|
144566
|
145022
|
145023
| 145141 |
145142