Bug 32349 - Remove TEST_QA
Summary: Remove TEST_QA
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
: 32347 (view as bug list)
Depends on: 5485
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-25 08:06 UTC by Jonathan Druart
Modified: 2023-12-28 20:44 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.02,22.05.09, 21.11.16


Attachments
Bug 32349: Remove TEST_QA (2.40 KB, patch)
2022-11-25 08:08 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32349: Remove TEST_QA (2.48 KB, patch)
2022-12-01 10:22 UTC, Mason James
Details | Diff | Splinter Review
Bug 32349: Remove TEST_QA (1.58 KB, patch)
2022-12-14 07:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32349: Remove TEST_QA (1.22 KB, patch)
2023-01-04 14:34 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32349: Remove find-nonutf8 tests (1.72 KB, patch)
2023-01-04 14:34 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32349: Remove TEST_QA (1.31 KB, patch)
2023-01-09 12:07 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32349: Remove find-nonutf8 tests (1.81 KB, patch)
2023-01-09 12:07 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-25 08:06:54 UTC
There is an env var that we are passing from koha-testing-docker, TEST_QA.
It's used in Koha from a single test file, t/00-testcritic.t.
If not set, no test is run.

Do we really need this? libtest-perl-critic-perl is packaged and automatically installed.
Comment 1 Jonathan Druart 2022-11-25 08:08:15 UTC
Created attachment 144226 [details] [review]
Bug 32349: Remove TEST_QA

There is an env var that we are passing from koha-testing-docker, TEST_QA.
It's used in Koha from a single test file, t/00-testcritic.t.
If not set, no test is run.

Do we really need this? libtest-perl-critic-perl is packaged and automatically installed.
Comment 2 Jonathan Druart 2022-11-25 08:09:04 UTC
Mason, you are the only one this removal could affect. Do you agree with this?
Comment 3 Mason James 2022-12-01 10:22:44 UTC
Created attachment 144374 [details] [review]
Bug 32349: Remove TEST_QA

There is an env var that we are passing from koha-testing-docker, TEST_QA.
It's used in Koha from a single test file, t/00-testcritic.t.
If not set, no test is run.

Do we really need this? libtest-perl-critic-perl is packaged and automatically installed.

Signed-off-by: Mason James <mtj@kohaaloha.com>
Comment 4 Mason James 2022-12-01 10:23:16 UTC
(In reply to Jonathan Druart from comment #2)
> Mason, you are the only one this removal could affect. Do you agree with
> this?

hiya, patch looks good to me :)
Comment 5 Marcel de Rooy 2022-12-09 10:36:36 UTC
diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl
index d2dfe1ad56..e95b1fa199 100755
--- a/misc/migration_tools/bulkmarcimport.pl
+++ b/misc/migration_tools/bulkmarcimport.pl
@@ -480,7 +480,7 @@ RECORD: while (  ) {
             C4::Biblio::_strip_item_fields($clone_record, '');
             # This sets the marc fields if there was an error, and also calls
             # defer_marc_save.
-            ModBiblioMarc( $clone_record, $biblionumber );
+            ModBiblioMarc( $clone_record, $biblionumber ) if $insert;

Please explain what this change does here?
Comment 6 Mason James 2022-12-12 04:01:18 UTC
(In reply to Marcel de Rooy from comment #5)
> diff --git a/misc/migration_tools/bulkmarcimport.pl
> b/misc/migration_tools/bulkmarcimport.pl
> index d2dfe1ad56..e95b1fa199 100755
> --- a/misc/migration_tools/bulkmarcimport.pl
> +++ b/misc/migration_tools/bulkmarcimport.pl
> @@ -480,7 +480,7 @@ RECORD: while (  ) {
>              C4::Biblio::_strip_item_fields($clone_record, '');
>              # This sets the marc fields if there was an error, and also
> calls
>              # defer_marc_save.
> -            ModBiblioMarc( $clone_record, $biblionumber );
> +            ModBiblioMarc( $clone_record, $biblionumber ) if $insert;
> 
> Please explain what this change does here?

oops, i think the change to bulkmarcimport.pl might be an accident?
Comment 7 Jonathan Druart 2022-12-14 07:57:37 UTC
Created attachment 144566 [details] [review]
Bug 32349: Remove TEST_QA

There is an env var that we are passing from koha-testing-docker, TEST_QA.
It's used in Koha from a single test file, t/00-testcritic.t.
If not set, no test is run.

Do we really need this? libtest-perl-critic-perl is packaged and automatically installed.

Signed-off-by: Mason James <mtj@kohaaloha.com>
Comment 8 Jonathan Druart 2022-12-14 07:58:04 UTC
Sorry, it was related to another bug.
Comment 9 Marcel de Rooy 2022-12-16 07:34:12 UTC
#!/usr/bin/perl

And a bit later:

set -e

git ls-files |
grep -Ev '\.(gif|jpg|png|pdf|ogg|psd|swf|odt|zip|ico|DS_Store|chr|dat)$' |
grep -v /js/tinymce/ |
while read filename
do
    if ! isutf8 -q "$filename"
    then
        echo "$filename"
    fi
done
Comment 10 Marcel de Rooy 2022-12-16 07:34:28 UTC
Not good enough for me :)
Comment 11 Jonathan Druart 2023-01-04 14:34:26 UTC
Created attachment 145022 [details] [review]
Bug 32349: Remove TEST_QA

There is an env var that we are passing from koha-testing-docker, TEST_QA.
It's used in Koha from a single test file, t/00-testcritic.t.
If not set, no test is run.

Do we really need this? libtest-perl-critic-perl is packaged and automatically installed.

Signed-off-by: Mason James <mtj@kohaaloha.com>
Comment 12 Jonathan Druart 2023-01-04 14:34:31 UTC
Created attachment 145023 [details] [review]
Bug 32349: Remove find-nonutf8 tests

We don't run it and it does not seem very useful. Let's remove it.
Comment 13 Jonathan Druart 2023-01-04 14:34:53 UTC
(In reply to Marcel de Rooy from comment #10)
> Not good enough for me :)

Oops, indeed!

I decided to remove it, what do you think?
Comment 14 Marcel de Rooy 2023-01-09 12:07:52 UTC
Created attachment 145141 [details] [review]
Bug 32349: Remove TEST_QA

There is an env var that we are passing from koha-testing-docker, TEST_QA.
It's used in Koha from a single test file, t/00-testcritic.t.
If not set, no test is run.

Do we really need this? libtest-perl-critic-perl is packaged and automatically installed.

Signed-off-by: Mason James <mtj@kohaaloha.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 15 Marcel de Rooy 2023-01-09 12:07:57 UTC
Created attachment 145142 [details] [review]
Bug 32349: Remove find-nonutf8 tests

We don't run it and it does not seem very useful. Let's remove it.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 16 Marcel de Rooy 2023-01-09 12:08:40 UTC
Moving furter to PQA
Comment 17 Marcel de Rooy 2023-01-09 12:09:05 UTC
(In reply to Jonathan Druart from comment #13)
> I decided to remove it, what do you think?

Agreed.
Comment 18 Tomás Cohen Arazi 2023-01-11 23:55:23 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 19 Jacob O'Mara 2023-01-13 16:24:47 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 20 Magnus Enger 2023-01-18 07:46:18 UTC
*** Bug 32347 has been marked as a duplicate of this bug. ***
Comment 21 Lucas Gass 2023-01-24 18:24:09 UTC
Backported to 22.05.xfor upcoming 22.05.09
Comment 22 Arthur Suzuki 2023-01-26 13:27:09 UTC
applied to 21.11.x for 21.11.16
Comment 23 wainuiwitikapark 2023-03-15 01:35:28 UTC
Not backported to 21.05.x