Bugzilla – Attachment 148765 Details for
Bug 33336
Use a dedicated column for plugin status in plugins table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33336: Use a dedicated column for plugin status in plugins table
Bug-33336-Use-a-dedicated-column-for-plugin-status.patch (text/plain), 3.60 KB, created by
ByWater Sandboxes
on 2023-03-27 13:06:23 UTC
(
hide
)
Description:
Bug 33336: Use a dedicated column for plugin status in plugins table
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2023-03-27 13:06:23 UTC
Size:
3.60 KB
patch
obsolete
>From 12b6d792f873469bd4675fde6b9a9ad42a6f2439 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 24 Mar 2023 15:19:06 -1000 >Subject: [PATCH] Bug 33336: Use a dedicated column for plugin status in > plugins table > >In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label. >With new interface ENABLED is yellow, this looks weird. >Also I bet this is bad for accessibility. > >I propose to move this info to a dedicated column. >I use bootstrap classes bg-success and bg-warning like in about.pl > >Test plan: >1) Install some plugins >2) Go to Administration > Manage plugins >3) Check you see table with column status >4) Disable a plugin >5) Check you see 'Disabled' in status > >Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> >--- > .../prog/en/modules/plugins/plugins-home.tt | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >index 775c3f0bba..4ecd40173b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >@@ -129,6 +129,7 @@ > <th>Minimum Koha version</th> > <th>Maximum Koha version</th> > <th>Last updated</th> >+ <th>Status</th> > [% IF ( CAN_user_plugins_configure || CAN_user_plugins_manage || CAN_user_plugins_report || CAN_user_plugins_tool ) %] > <th class="noExport">Actions</th> > [% END %] >@@ -152,11 +153,6 @@ > <tr> > <td> > <strong>[% plugin.metadata.name | html %]</strong> >- [% IF ( plugin.is_enabled ) %] >- <span class="label label-primary">ENABLED</span> >- [% ELSE %] >- <span class="label label-default">DISABLED</span> >- [% END %] > </td> > <td> > [% plugin.metadata.description | html %] >@@ -178,6 +174,13 @@ > <td>[% plugin.metadata.minimum_version | html %]</td> > <td>[% plugin.metadata.maximum_version | html %]</td> > <td>[% plugin.metadata.date_updated | $KohaDates %]</td> >+ <td> >+ [% IF ( plugin.is_enabled ) %] >+ <span class="bg-success">Enabled</span> >+ [% ELSE %] >+ <span class="bg-warning">Disabled</span> >+ [% END %] >+ </td> > [% IF ( CAN_user_plugins_configure || CAN_user_plugins_manage || CAN_user_plugins_report || CAN_user_plugins_tool ) %] > <td class="actions"> > <div class="btn-group dropup"> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33336
:
148697
|
148698
|
148765
|
149360