Bug 33336 - Use a dedicated column for plugin status in plugins table
Summary: Use a dedicated column for plugin status in plugins table
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-25 01:18 UTC by Fridolin Somers
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00, 22.11.06


Attachments
Bug 33336: Use a dedicated column for plugin status in plugins table (3.06 KB, patch)
2023-03-25 01:19 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 33336: Use a dedicated column for plugin status in plugins table (3.53 KB, patch)
2023-03-25 06:52 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 33336: Use a dedicated column for plugin status in plugins table (3.60 KB, patch)
2023-03-27 13:06 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33336: Use a dedicated column for plugin status in plugins table (3.66 KB, patch)
2023-04-09 12:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-03-25 01:18:24 UTC
In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label.
With new interface ENABLED is yellow, this looks weird.
Also I bet this is bad for accessibility.
I propose to move this info to a dedicated column.
Comment 1 Fridolin Somers 2023-03-25 01:19:59 UTC
Created attachment 148697 [details] [review]
Bug 33336: Use a dedicated column for plugin status in plugins table

WIP
Comment 2 Fridolin Somers 2023-03-25 06:52:52 UTC
Created attachment 148698 [details] [review]
Bug 33336: Use a dedicated column for plugin status in plugins table

In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label.
With new interface ENABLED is yellow, this looks weird.
Also I bet this is bad for accessibility.

I propose to move this info to a dedicated column.
I use bootstrap classes bg-success and bg-warning like in about.pl

Test plan:
1) Install some plugins
2) Go to Administration > Manage plugins
3) Check you see table with column status
4) Disable a plugin
5) Check you see 'Disabled' in status
Comment 3 ByWater Sandboxes 2023-03-27 13:06:23 UTC
Created attachment 148765 [details] [review]
Bug 33336: Use a dedicated column for plugin status in plugins table

In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label.
With new interface ENABLED is yellow, this looks weird.
Also I bet this is bad for accessibility.

I propose to move this info to a dedicated column.
I use bootstrap classes bg-success and bg-warning like in about.pl

Test plan:
1) Install some plugins
2) Go to Administration > Manage plugins
3) Check you see table with column status
4) Disable a plugin
5) Check you see 'Disabled' in status

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 4 Katrin Fischer 2023-04-09 12:10:31 UTC
Created attachment 149360 [details] [review]
Bug 33336: Use a dedicated column for plugin status in plugins table

In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label.
With new interface ENABLED is yellow, this looks weird.
Also I bet this is bad for accessibility.

I propose to move this info to a dedicated column.
I use bootstrap classes bg-success and bg-warning like in about.pl

Test plan:
1) Install some plugins
2) Go to Administration > Manage plugins
3) Check you see table with column status
4) Disable a plugin
5) Check you see 'Disabled' in status

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-04-13 14:49:52 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-04-17 09:16:07 UTC
Enhancement - not backporting to 22.11.x

Nice work everyone!
Comment 7 Fridolin Somers 2023-04-21 06:59:46 UTC
(In reply to Matt Blenkinsop from comment #6)
> Enhancement - not backporting to 22.11.x
> 
> Nice work everyone!

Hi,

This is a really trivial patch, but the change is really useful for end users.
Could you reconsider backporting ?
Comment 8 Matt Blenkinsop 2023-04-21 08:23:47 UTC
Hi Fridolin, I'm happy to backport this but we are currently in string freeze as we head towards this months release. We'll backport this at the start of next month once this release is finished
Comment 9 Fridolin Somers 2023-04-28 08:47:55 UTC
(In reply to Matt Blenkinsop from comment #8)
> Hi Fridolin, I'm happy to backport this but we are currently in string
> freeze as we head towards this months release. We'll backport this at the
> start of next month once this release is finished

Great
Comment 10 Martin Renvoize 2023-05-11 10:24:41 UTC
Pushed to 22.11.x for 22.11.06 release.  Thanks everyone.
Comment 11 Lucas Gass 2023-05-15 21:32:53 UTC
Does not apply cleanly to 22.05.x, no backport.