In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label. With new interface ENABLED is yellow, this looks weird. Also I bet this is bad for accessibility. I propose to move this info to a dedicated column.
Created attachment 148697 [details] [review] Bug 33336: Use a dedicated column for plugin status in plugins table WIP
Created attachment 148698 [details] [review] Bug 33336: Use a dedicated column for plugin status in plugins table In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label. With new interface ENABLED is yellow, this looks weird. Also I bet this is bad for accessibility. I propose to move this info to a dedicated column. I use bootstrap classes bg-success and bg-warning like in about.pl Test plan: 1) Install some plugins 2) Go to Administration > Manage plugins 3) Check you see table with column status 4) Disable a plugin 5) Check you see 'Disabled' in status
Created attachment 148765 [details] [review] Bug 33336: Use a dedicated column for plugin status in plugins table In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label. With new interface ENABLED is yellow, this looks weird. Also I bet this is bad for accessibility. I propose to move this info to a dedicated column. I use bootstrap classes bg-success and bg-warning like in about.pl Test plan: 1) Install some plugins 2) Go to Administration > Manage plugins 3) Check you see table with column status 4) Disable a plugin 5) Check you see 'Disabled' in status Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 149360 [details] [review] Bug 33336: Use a dedicated column for plugin status in plugins table In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label. With new interface ENABLED is yellow, this looks weird. Also I bet this is bad for accessibility. I propose to move this info to a dedicated column. I use bootstrap classes bg-success and bg-warning like in about.pl Test plan: 1) Install some plugins 2) Go to Administration > Manage plugins 3) Check you see table with column status 4) Disable a plugin 5) Check you see 'Disabled' in status Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Enhancement - not backporting to 22.11.x Nice work everyone!
(In reply to Matt Blenkinsop from comment #6) > Enhancement - not backporting to 22.11.x > > Nice work everyone! Hi, This is a really trivial patch, but the change is really useful for end users. Could you reconsider backporting ?
Hi Fridolin, I'm happy to backport this but we are currently in string freeze as we head towards this months release. We'll backport this at the start of next month once this release is finished
(In reply to Matt Blenkinsop from comment #8) > Hi Fridolin, I'm happy to backport this but we are currently in string > freeze as we head towards this months release. We'll backport this at the > start of next month once this release is finished Great
Pushed to 22.11.x for 22.11.06 release. Thanks everyone.
Does not apply cleanly to 22.05.x, no backport.