Bugzilla – Attachment 149320 Details for
Bug 33293
Use template wrapper for tabs: Holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33293: Use template wrapper for tabs: Holds
Bug-33293-Use-template-wrapper-for-tabs-Holds.patch (text/plain), 4.25 KB, created by
Katrin Fischer
on 2023-04-08 21:42:05 UTC
(
hide
)
Description:
Bug 33293: Use template wrapper for tabs: Holds
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-04-08 21:42:05 UTC
Size:
4.25 KB
patch
obsolete
>From b6edc76654ab234a7f63029e2b8af845f86ee94e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 21 Mar 2023 16:25:48 +0000 >Subject: [PATCH] Bug 33293: Use template wrapper for tabs: Holds > >This patch updates the holds template so that it uses the new WRAPPER >directive to build tabbed navigation. > >Note: this patch includes indentation changes, so check the diff >accordingly. > >To test, apply the patch and locate a bibliographic record which >can be placed on hold. > >- Start the process of placing a hold. >- If you have any patron clubs defined, there should be two tabs: > Patrons and Clubs. Both should look correct and work correctly. >- If you have no patron clubs you should see only the Patrons tab. > >Works as advertised. > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/modules/reserve/request.tt | 28 ++++++++++--------- > 1 file changed, 15 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index e2d33c5415..6ce054fffc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -227,21 +227,23 @@ > <h2>Search patrons</h2> > [% END %] > [% END %] >- <div id="circ_holds_select" class="toptabs"> >- <ul class="nav nav-tabs" role="tablist"> >- <li role="presentation" class="active"><a href="#holds_patronsearch_pane" aria-controls="holds_patronsearch_pane" role="tab" data-toggle="tab">Patrons</a></li> >+ >+ [% WRAPPER tabs id= "circ_holds_select" %] >+ [% WRAPPER tabs_nav %] >+ [% WRAPPER tab_item tabname= "holds_patronsearch_pane" bt_active= 1 %] <span>Patrons</span> [% END %] > [% IF clubcount %] >- <li role="presentation"><a href="#holds_clubsearch_pane" aria-controls="holds_clubsearch_pane" role="tab" data-toggle="tab">Clubs</a></li> >+ [% WRAPPER tab_item tabname= "holds_clubsearch_pane" %] <span>Clubs</span> [% END %] > [% END %] >- </ul> >- <div class="tab-content"> >- <div id="holds_patronsearch_pane" role="tabpanel" class="tab-pane active"> >+ [% END # /WRAPPER tabs_nav %] >+ >+ [% WRAPPER tab_panels %] >+ [% WRAPPER tab_panel tabname="holds_patronsearch_pane" bt_active= 1 %] > [% PROCESS patron_search_filters_simple %] > > [% PROCESS patron_search_table table_id => 'table_borrowers', open_on_row_click => 1 %] >- </div> >+ [% END # /tab_panel# %] > [% IF clubcount %] >- <div id="holds_clubsearch_pane" role="tabpanel" class="tab-pane"> >+ [% WRAPPER tab_panel tabname="holds_clubsearch_pane" %] > <form id="holds_clubsearch" action="request.pl" method="post"> > <div class="hint">Enter club ID or partial name:</div> > <input type="text" size="40" id="club" class="focus" name="findclub" autocomplete="off" /> >@@ -254,10 +256,10 @@ > [% IF clubs %] > [% INCLUDE 'clubs-table.inc' destination = "holds" %] > [% END %] >- </div> >- [% END %] >- </div> <!-- /.tab-content --> >- </div> >+ [% END # /tab_panel# %] >+ [% END # /IF clubcount %] >+ [% END # /WRAPPER tab_panels %] >+ [% END # /WRAPPER tabs %] > </fieldset> > [% ELSIF club %] > <div class="dialog alert hide clubalert"> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33293
:
148483
|
148753
| 149320