Bug 33293 - Use template wrapper for tabs: Holds
Summary: Use template wrapper for tabs: Holds
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32571
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-21 16:20 UTC by Owen Leonard
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33293: Use template wrapper for tabs: Holds (4.11 KB, patch)
2023-03-21 16:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33293: Use template wrapper for tabs: Holds (4.21 KB, patch)
2023-03-27 11:37 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 33293: Use template wrapper for tabs: Holds (4.25 KB, patch)
2023-04-08 21:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-21 16:20:28 UTC
Continuing the work of Bug 32571, I would like to update the holds page in the staff client to use the new WRAPPER for tabs
Comment 1 Owen Leonard 2023-03-21 16:40:04 UTC
Created attachment 148483 [details] [review]
Bug 33293: Use template wrapper for tabs: Holds

This patch updates the holds template so that it uses the new WRAPPER
directive to build tabbed navigation.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and locate a bibliographic record which
can be placed on hold.

- Start the process of placing a hold.
- If you have any patron clubs defined, there should be two tabs:
  Patrons and Clubs. Both should look correct and work correctly.
- If you have no patron clubs you should see only the Patrons tab.
Comment 2 Paul Derscheid 2023-03-27 11:37:36 UTC
Created attachment 148753 [details] [review]
Bug 33293: Use template wrapper for tabs: Holds

This patch updates the holds template so that it uses the new WRAPPER
directive to build tabbed navigation.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and locate a bibliographic record which
can be placed on hold.

- Start the process of placing a hold.
- If you have any patron clubs defined, there should be two tabs:
  Patrons and Clubs. Both should look correct and work correctly.
- If you have no patron clubs you should see only the Patrons tab.

Works as advertised.

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 3 Katrin Fischer 2023-04-08 21:42:05 UTC
Created attachment 149320 [details] [review]
Bug 33293: Use template wrapper for tabs: Holds

This patch updates the holds template so that it uses the new WRAPPER
directive to build tabbed navigation.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and locate a bibliographic record which
can be placed on hold.

- Start the process of placing a hold.
- If you have any patron clubs defined, there should be two tabs:
  Patrons and Clubs. Both should look correct and work correctly.
- If you have no patron clubs you should see only the Patrons tab.

Works as advertised.

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-13 14:49:37 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:37:53 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.