Continuing the work of Bug 32571, I would like to update the holds page in the staff client to use the new WRAPPER for tabs
Created attachment 148483 [details] [review] Bug 33293: Use template wrapper for tabs: Holds This patch updates the holds template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and locate a bibliographic record which can be placed on hold. - Start the process of placing a hold. - If you have any patron clubs defined, there should be two tabs: Patrons and Clubs. Both should look correct and work correctly. - If you have no patron clubs you should see only the Patrons tab.
Created attachment 148753 [details] [review] Bug 33293: Use template wrapper for tabs: Holds This patch updates the holds template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and locate a bibliographic record which can be placed on hold. - Start the process of placing a hold. - If you have any patron clubs defined, there should be two tabs: Patrons and Clubs. Both should look correct and work correctly. - If you have no patron clubs you should see only the Patrons tab. Works as advertised. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Created attachment 149320 [details] [review] Bug 33293: Use template wrapper for tabs: Holds This patch updates the holds template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and locate a bibliographic record which can be placed on hold. - Start the process of placing a hold. - If you have any patron clubs defined, there should be two tabs: Patrons and Clubs. Both should look correct and work correctly. - If you have no patron clubs you should see only the Patrons tab. Works as advertised. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.