Bugzilla – Attachment 150460 Details for
Bug 33590
WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt
Bug-33590-Fix-DOM-id-name-for-tabs-after-WRAPPER-c.patch (text/plain), 1.94 KB, created by
Caroline Cyr La Rose
on 2023-05-01 15:22:51 UTC
(
hide
)
Description:
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt
Filename:
MIME Type:
Creator:
Caroline Cyr La Rose
Created:
2023-05-01 15:22:51 UTC
Size:
1.94 KB
patch
obsolete
>From 841bc7f54ea137f4a16037b04a27bc3b8703a4de Mon Sep 17 00:00:00 2001 >From: Slava Shishkin <slavashishkin@gmail.com> >Date: Fri, 28 Apr 2023 16:36:23 +0300 >Subject: [PATCH] Bug 33590: Fix DOM id name for tabs after WRAPPER code added > to export.tt > >The list of CSV profiles was not displayed if the CSV format was selected in the output format settings. > >To test: >1. Go to /cgi-bin/koha/tools/export.pl >2. At the bottom of the page in the Output format, select SCV format. > *If SCV format is not active in the drop-down File format menu, create any profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl >3. Note that the list of SCV profiles is not displayed. >4. Apply the patch. >5. Restart the page and repeat steps 2. >6. Verify that when you select the CSV format, the list of CSV profiles appears. > >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt >index ebd30b6202..59f850f22b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt >@@ -336,12 +336,12 @@ > > $("li.csv_profiles").hide(); > >- $("#bibs select[name='output_format']").on('change', function(){ >+ $("#bibs_panel select[name='output_format']").on('change', function(){ > var format = $(this).val(); > if ( format == 'csv' ) { >- $("#bibs li.csv_profiles").show(); >+ $("#bibs_panel li.csv_profiles").show(); > } else { >- $("#bibs li.csv_profiles").hide(); >+ $("#bibs_panel li.csv_profiles").hide(); > } > }); > $("#checkall").on("click",function(e){ >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33590
:
150250
|
150251
|
150298
|
150377
|
150457
|
150458
|
150459
|
150460
|
150549
|
150550
|
150551
|
150552