Bug 33590 - WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)
Summary: WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax up...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Slava Shishkin
QA Contact: Katrin Fischer
URL:
Keywords:
: 33679 (view as bug list)
Depends on: 32571
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-23 09:47 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt (2.64 KB, patch)
2023-04-26 17:40 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt (1.84 KB, patch)
2023-04-26 17:40 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt (2.03 KB, patch)
2023-04-27 13:24 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt (1.87 KB, patch)
2023-04-28 13:36 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt (2.71 KB, patch)
2023-05-01 15:22 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt (1.92 KB, patch)
2023-05-01 15:22 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt (2.10 KB, patch)
2023-05-01 15:22 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt (1.94 KB, patch)
2023-05-01 15:22 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt (2.71 KB, patch)
2023-05-02 22:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt (1.92 KB, patch)
2023-05-02 22:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt (2.16 KB, patch)
2023-05-02 22:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt (2.00 KB, patch)
2023-05-02 22:19 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-23 09:47:33 UTC
The select all/clear all links to select items for editing or deleting on the serial collection page are broken and there is no reaction when clicking on them.

To test:
* Add a subscription
* From the subscription detail page, click on serial collection link in left hand navigation
* Create some additional issues
* Clear all link for selecting issues to edit won't work, select all link neither
Comment 1 Slava Shishkin 2023-04-26 15:01:44 UTC
I found the same issues on another page – /cgi-bin/koha/circ/article-requests.pl
 
It is possible that problems occur on other pages where wrappers have been applied. I will check and prepare a correction.
Comment 2 Slava Shishkin 2023-04-26 17:40:21 UTC
Created attachment 150250 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt

This commit fixed two cases:
1. Fixing "Select all" and "Clear all" links on the page.
2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs.

To test:
(Create article requests if they don't exist)

Case 1:
1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs.
2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected.
3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared.
4. Apply the patch.
5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now.

Case 2:
1. Go to /cgi-bin/koha/circ/article-requests.pl.
2. Switch between tabs and leave "New" active.
3. Select any entry and delete or move it to another tab.
4. Verify that the entry remains in the table until the page reloads.
5. Apply the patch.
6. Restart the page and repeat steps 2 and 3. Make sure that everything works now.
Comment 3 Slava Shishkin 2023-04-26 17:40:24 UTC
Created attachment 150251 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt

To test:
* Add a subscription
* From the subscription detail page, click on serial collection link in left hand navigation
* Create some additional issues
* "Clear all" link for selecting issues to edit won't work, "Select all" link neither
* Apply the patch *
* "Clear all" link for selecting issues to edit works now, "Select all" link works too.
Comment 4 Slava Shishkin 2023-04-27 13:24:12 UTC
Created attachment 150298 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt

The submitted numbers were not processed by the search query.

To test:
1. Go to /cgi-bin/koha/circ/modborrowers.pl
2. On the relevant tab, enter the card number or the borrower number in the text area, or upload a text file with a relevant list of numbers.
3. Click "Continue" and verify that a message appears stating "No patron card numbers or borrowernumbers given".
4. Apply the patch.
5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct response -- a list of borrowers or a message indicating that the specified numbers were not found.
Comment 5 Katrin Fischer 2023-04-27 21:10:34 UTC
Hi Slava, is this ready for testing?
Comment 6 Slava Shishkin 2023-04-28 13:36:58 UTC
Created attachment 150377 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt

The list of CSV profiles was not displayed if the CSV format was selected in the output format settings.

To test:
1. Go to /cgi-bin/koha/tools/export.pl
2. At the bottom of the page in the Output format, select SCV format.
  *If SCV format is not active in the drop-down File format menu, create any profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl
3. Note that the list of SCV profiles is not displayed.
4. Apply the patch.
5. Restart the page and repeat steps 2.
6. Verify that when you select the CSV format, the list of CSV profiles appears.
Comment 7 Slava Shishkin 2023-04-28 14:18:11 UTC
Hi Katrin!

Here, I found another case, which I added above. 
That's all I found, for now, can be test it. 
If I find something later, I'll create a new ticket.
Comment 8 Caroline Cyr La Rose 2023-05-01 15:22:43 UTC
Created attachment 150457 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt

This commit fixed two cases:
1. Fixing "Select all" and "Clear all" links on the page.
2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs.

To test:
(Create article requests if they don't exist)

Case 1:
1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs.
2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected.
3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared.
4. Apply the patch.
5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now.

Case 2:
1. Go to /cgi-bin/koha/circ/article-requests.pl.
2. Switch between tabs and leave "New" active.
3. Select any entry and delete or move it to another tab.
4. Verify that the entry remains in the table until the page reloads.
5. Apply the patch.
6. Restart the page and repeat steps 2 and 3. Make sure that everything works now.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 9 Caroline Cyr La Rose 2023-05-01 15:22:46 UTC
Created attachment 150458 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt

To test:
* Add a subscription
* From the subscription detail page, click on serial collection link in left hand navigation
* Create some additional issues
* "Clear all" link for selecting issues to edit won't work, "Select all" link neither
* Apply the patch *
* "Clear all" link for selecting issues to edit works now, "Select all" link works too.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 10 Caroline Cyr La Rose 2023-05-01 15:22:48 UTC
Created attachment 150459 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt

The submitted numbers were not processed by the search query.

To test:
1. Go to /cgi-bin/koha/circ/modborrowers.pl
2. On the relevant tab, enter the card number or the borrower number in the text area, or upload a text file with a relevant list of numbers.
3. Click "Continue" and verify that a message appears stating "No patron card numbers or borrowernumbers given".
4. Apply the patch.
5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct response -- a list of borrowers or a message indicating that the specified numbers were not found.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 11 Caroline Cyr La Rose 2023-05-01 15:22:51 UTC
Created attachment 150460 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt

The list of CSV profiles was not displayed if the CSV format was selected in the output format settings.

To test:
1. Go to /cgi-bin/koha/tools/export.pl
2. At the bottom of the page in the Output format, select SCV format.
  *If SCV format is not active in the drop-down File format menu, create any profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl
3. Note that the list of SCV profiles is not displayed.
4. Apply the patch.
5. Restart the page and repeat steps 2.
6. Verify that when you select the CSV format, the list of CSV profiles appears.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 12 Caroline Cyr La Rose 2023-05-01 15:24:14 UTC
I tested the 4.5 scenarios (serial collection, article requests (cases 1 and 2), patron batch modification and catalog export) and everything works with the patch.

Thank you!
Comment 13 Katrin Fischer 2023-05-02 22:19:30 UTC
Created attachment 150549 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt

This commit fixed two cases:
1. Fixing "Select all" and "Clear all" links on the page.
2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs.

To test:
(Create article requests if they don't exist)

Case 1:
1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs.
2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected.
3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared.
4. Apply the patch.
5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now.

Case 2:
1. Go to /cgi-bin/koha/circ/article-requests.pl.
2. Switch between tabs and leave "New" active.
3. Select any entry and delete or move it to another tab.
4. Verify that the entry remains in the table until the page reloads.
5. Apply the patch.
6. Restart the page and repeat steps 2 and 3. Make sure that everything works now.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 14 Katrin Fischer 2023-05-02 22:19:33 UTC
Created attachment 150550 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt

To test:
* Add a subscription
* From the subscription detail page, click on serial collection link in left hand navigation
* Create some additional issues
* "Clear all" link for selecting issues to edit won't work, "Select all" link neither
* Apply the patch *
* "Clear all" link for selecting issues to edit works now, "Select all" link works too.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 15 Katrin Fischer 2023-05-02 22:19:35 UTC
Created attachment 150551 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt

The submitted numbers were not processed by the search query.

To test:
1. Go to /cgi-bin/koha/circ/modborrowers.pl
2. On the relevant tab, enter the card number or the borrower number in the text area, or upload a text file with a relevant list of numbers.
3. Click "Continue" and verify that a message appears stating "No patron card numbers or borrowernumbers given".
4. Apply the patch.
5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct response -- a list of borrowers or a message indicating that the specified numbers were not found.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 16 Katrin Fischer 2023-05-02 22:19:38 UTC
Created attachment 150552 [details] [review]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt

The list of CSV profiles was not displayed if the CSV format was selected in the output format settings.

To test:
1. Go to /cgi-bin/koha/tools/export.pl
2. At the bottom of the page in the Output format, select CSV format.
  *If CSV format is not active in the drop-down File format menu, create
   any profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl
3. Note that the list of CSV profiles is not displayed.
4. Apply the patch.
5. Restart the page and repeat steps 2.
6. Verify that when you select the CSV format, the list of CSV profiles appears.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 17 Katrin Fischer 2023-05-04 14:21:11 UTC
*** Bug 33679 has been marked as a duplicate of this bug. ***
Comment 18 Tomás Cohen Arazi 2023-05-05 12:18:06 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 19 Martin Renvoize 2023-05-11 11:00:14 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 20 Lucas Gass 2023-05-15 21:55:07 UTC
Not needed for 22.05.x, no backport