Bugzilla – Attachment 150551 Details for
Bug 33590
WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt
Bug-33590-Fix-DOM-id-name-for-tabs-after-WRAPPER-c.patch (text/plain), 2.16 KB, created by
Katrin Fischer
on 2023-05-02 22:19:35 UTC
(
hide
)
Description:
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-05-02 22:19:35 UTC
Size:
2.16 KB
patch
obsolete
>From eb5ca549a21d6479cd2271747e42b480747f5fdd Mon Sep 17 00:00:00 2001 >From: Slava Shishkin <slavashishkin@gmail.com> >Date: Thu, 27 Apr 2023 16:23:42 +0300 >Subject: [PATCH] Bug 33590: Fix DOM id name for tabs after WRAPPER code added > to modborrowers.tt > >The submitted numbers were not processed by the search query. > >To test: >1. Go to /cgi-bin/koha/circ/modborrowers.pl >2. On the relevant tab, enter the card number or the borrower number in the text area, or upload a text file with a relevant list of numbers. >3. Click "Continue" and verify that a message appears stating "No patron card numbers or borrowernumbers given". >4. Apply the patch. >5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct response -- a list of borrowers or a message indicating that the specified numbers were not found. > >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >index fdd054868a..7a1a4139be 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >@@ -482,9 +482,9 @@ > $("#patron_batchmod_form").on("submit", function(){ > /* Reset form fields on inactive tabs */ > var tab = $(this).find('ul.nav-tabs li.active a').attr('href'); >- if ( tab == '#usecardnumber' ) { >+ if ( tab == '#usecardnumber_panel' ) { > $("#borrowernumberuploadfile, #patron_list_id, #borrowernumberlist").val(""); >- } else if ( tab == '#useborrowernumber' ) { >+ } else if ( tab == '#useborrowernumber_panel' ) { > $("#cardnumberuploadfile, #cardnumberlist, #patron_list_id").val(""); > } else { // uselist > $("#borrowernumberuploadfile, #cardnumberuploadfile, #borrowernumberlist, #cardnumberlist").val(""); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33590
:
150250
|
150251
|
150298
|
150377
|
150457
|
150458
|
150459
|
150460
|
150549
|
150550
| 150551 |
150552